Fix/fix wordpress version - #70
Draft
RobjS wants to merge 2 commits into
Draft
Conversation
Before: often the WORDPRESS_VERSION set as an env var would not be applied. This was because the `core update` command was running before the database connection was ready, so it would fail silently. Now: We wait for the database connection to be ready before running `core update`, so the latest version is applied correctly. We also set a default `WORDPRESS_VERSION` of `latest`, so this process will not fail if `WORDPRESS_VERSION` is set as a null value.
Before: `WORDPRESS_AUTO_UPDATE_CORE` would always use the default value of true. This meant that even if we successfully set an old WORDPRESS_VERSION env var, it would often then immediately update itself back to the correct version. Now: if a `WORDPRESS_VERSION` env var is set, `WORDPRESS_AUTO_UPDATE_CORE` will always be false. If a `WORDPRESS_AUTO_UPDATE_CORE` env var is set (and a `WORDPRESS_VERSION` is not), it will use that value. If neither are set, it defaults back to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.