Skip to content

fix: do not sign Content-Length/Content-Type on bodyless DELETE requests #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eldon-databanx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not sign Content-Length/Content-Type on bodyless DELETE requests #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions s3/src/request/request_trait.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,16 @@ pub trait Request {
Command::GetObjectTagging => {}
Command::GetBucketLocation => {}
Command::ListBuckets => {}
// Bodyless DELETE requests must not sign Content-Length/Content-Type:
// the HTTP client never transmits them, so strict SigV4 validators
// (e.g. Cloudflare R2) reconstruct a different canonical request and
// reject with SignatureDoesNotMatch (see issue #466).
Command::DeleteObject
| Command::DeleteObjectTagging
| Command::AbortMultipartUpload { .. }
| Command::DeleteBucket
| Command::DeleteBucketCors { .. }
| Command::DeleteBucketLifecycle => {}
_ => {
headers.insert(
CONTENT_LENGTH,
Expand Down