You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Leemxiey The issue is assigned to you, but the two content commits (28731ea3 and 9ac42ed2) are authored by Ssoleed. Re-author them under your own account and confirm the work is yours, or open the PR from the account that did the work. I cannot review it until the authorship matches the assignee. The PR also includes packages/api-core/src/positions.ts and its test from open PR #1216, which is unrelated to #1136. Remove that change and the commit that introduces it. Fill in the PR description as well. The current body is the unfilled template.
@Leemxiey Closing this PR. The content commits are authored by Ssoleed while the issue is assigned to you, and the PR includes the positions.ts change from open PR #1216, which is unrelated to #1136. Open a new PR under the assigned account with only the #1136 changes if you want this reviewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pnpm lint && pnpm typecheck && pnpm testpass locallyCloses #1136