Skip to content

Fix/1136 check read errors - #1224

Closed
Leemxiey wants to merge 3 commits into
drydocs:mainfrom
Leemxiey:fix/1136-check-read-errors
Closed

Leemxiey wants to merge 3 commits into
drydocs:mainfrom
Leemxiey:fix/1136-check-read-errors

Conversation

@Leemxiey

Copy link
Copy Markdown

Summary

Test plan

  • pnpm lint && pnpm typecheck && pnpm test pass locally
  • [ ]

Closes #1136

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown

@Ssoleed is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 22, 2026

Copy link
Copy Markdown

@Leemxiey Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@collinsezedike

Copy link
Copy Markdown
Collaborator

@Leemxiey The issue is assigned to you, but the two content commits (28731ea3 and 9ac42ed2) are authored by Ssoleed. Re-author them under your own account and confirm the work is yours, or open the PR from the account that did the work. I cannot review it until the authorship matches the assignee. The PR also includes packages/api-core/src/positions.ts and its test from open PR #1216, which is unrelated to #1136. Remove that change and the commit that introduces it. Fill in the PR description as well. The current body is the unfilled template.

@collinsezedike

Copy link
Copy Markdown
Collaborator

@Leemxiey Closing this PR. The content commits are authored by Ssoleed while the issue is assigned to you, and the PR includes the positions.ts change from open PR #1216, which is unrelated to #1136. Open a new PR under the assigned account with only the #1136 changes if you want this reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Trustline and faucet checks fail open on read errors

3 participants