Skip to content

Migrate share-link create/update dry-run to renderOperation #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyVMarkelov merged 1 commit into from
Jul 10, 2026
+10 −8
Merged

Migrate share-link create/update dry-run to renderOperation #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmd/share_link_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,15 @@ func plannedShareLinkCreateMetadata(path string) shareLinkJSONMetadata {

func renderShareLinkCreateDryRunOutput(cmd *cobra.Command, path string, opts shareLinkCreateOptions) error {
result := plannedShareLinkCreateMetadata(path)
return commandOutput(cmd).Render(func(w io.Writer) error {
return writeDryRunLine(w, "create shared link", path)
}, newJSONCommandOperationOutput(
return renderOperation(
cmd,
newShareLinkCreateInput(path, opts),
[]jsonOperationResult{shareLinkCreateOperationResult(shareLinkJSONStatusCreated, result, opts)},
nil,
))
func(w io.Writer) error {
return writeDryRunLine(w, "create shared link", path)
},
)
}

func applyExistingSharedLinkCreateOptions(dbx sharedLinkClient, link sharing.IsSharedLinkMetadata, opts shareLinkCreateOptions) (sharing.IsSharedLinkMetadata, error) {
Expand Down
9 changes: 5 additions & 4 deletions cmd/share_link_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,14 +279,15 @@ func plannedShareLinkUpdateMetadata(url string) shareLinkJSONMetadata {

func renderShareLinkUpdateDryRunOutput(cmd *cobra.Command, url string, opts shareLinkUpdateOptions) error {
result := plannedShareLinkUpdateMetadata(url)
return commandOutput(cmd).Render(func(w io.Writer) error {
return writeDryRunLine(w, "update shared link", url)
}, newJSONCommandOperationOutput(
return renderOperation(
cmd,
newShareLinkUpdateInput(url, opts),
[]jsonOperationResult{shareLinkUpdateOperationResult(shareLinkJSONStatusUpdated, result, opts)},
nil,
))
func(w io.Writer) error {
return writeDryRunLine(w, "update shared link", url)
},
)
}

var shareLinkUpdateCmd = &cobra.Command{
Expand Down
Loading