Feat unit tests#599
Open
KamToHung wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit tests in test-core to validate timeout alarm behavior, CPU metrics collection behavior, and notice dispatch behavior in the DynamicTp core components.
Changes:
- Added tests for
RunTimeoutTimerTaskto verify timeout counting, alarm triggering, and optional thread interruption. - Extended
SystemMetricsCaptorTestwith cases verifyingCpuMetricsCaptorCPU usage updates and exception handling. - Added
NoticeManagerTestto verify CHANGE notice dispatch behavior through the notify invoker chain.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/test-core/src/test/java/org/dromara/dynamictp/test/core/timer/RunTimeoutTimerTaskTest.java |
New unit tests for run-timeout timer task counting, alarm call, and interrupt behavior. |
test/test-core/src/test/java/org/dromara/dynamictp/test/core/system/SystemMetricsCaptorTest.java |
Additional CPU metrics tests using controlled CPU time via static mocking and reflection. |
test/test-core/src/test/java/org/dromara/dynamictp/test/core/notify/manager/NoticeManagerTest.java |
New unit test verifying CHANGE notice dispatch by temporarily overriding the notify invoker chain head. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+63
| @ExtendWith(SpringExtension.class) | ||
| @ContextConfiguration(classes = NoticeManagerTest.ContextConfig.class) | ||
| @Execution(ExecutionMode.SAME_THREAD) | ||
| class NoticeManagerTest { |
Collaborator
|
把ci的 error修下吧 |
Collaborator
Author
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.