Skip to content

hide token secret in personal access token read endpoints #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saddamr3e wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hide token secret in personal access token read endpoints #4826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd0eac6
hide token secret in personal access token read endpoints
saddamr3e Jun 17, 2026
1765f1b
rename personalAccessTokens slice in GetPersonalAccessTokens
saddamr3e Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions manager/service/personal_access_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,18 +84,27 @@ func (s *service) GetPersonalAccessToken(ctx context.Context, id uint) (*models.
return nil, err
}

// The token is a secret credential and is only returned once on creation,
// do not expose it on read paths.
personalAccessToken.Token = ""
return &personalAccessToken, nil
}

func (s *service) GetPersonalAccessTokens(ctx context.Context, q types.GetPersonalAccessTokensQuery) ([]models.PersonalAccessToken, int64, error) {
var count int64
personalAccessToken := []models.PersonalAccessToken{}
personalAccessTokens := []models.PersonalAccessToken{}
if err := s.db.WithContext(ctx).Scopes(models.Paginate(q.Page, q.PerPage)).Where(&models.PersonalAccessToken{
State: q.State,
UserID: q.UserID,
}).Preload("User").Find(&personalAccessToken).Limit(-1).Offset(-1).Count(&count).Error; err != nil {
}).Preload("User").Find(&personalAccessTokens).Limit(-1).Offset(-1).Count(&count).Error; err != nil {
return nil, 0, err
}

return personalAccessToken, count, nil
// The token is a secret credential and is only returned once on creation,
// do not expose it on read paths.
for i := range personalAccessTokens {
personalAccessTokens[i].Token = ""
}

return personalAccessTokens, count, nil
}
Loading