Repository navigation
Harden chart node data, rendering, and lifecycle - #9
Merged
Merged
Conversation
dovvnloading
added a commit
that referenced
this pull request
Jul 18, 2026
…27) Two related documentation cleanups. Document the branch/PR/merge workflow. CONTRIBUTING.md covered PR content expectations but never described branching or merge mechanics, even though the commit history has followed a consistent convention for 26 PRs. Writes down what was already practice: topic branches off main, agent/<slug> naming, push, PR via the existing template, squash-merge, delete branch. Also corrects README.md, which still claimed a GitHub Actions workflow runs a compile check on every push - that automation was removed in 185143a, so local validation is now the only gate. Remove references to gitignored planning docs. 65 tracked files carried 79 citations like "see doc/ARCHITECTURE_REVIEW_FINDINGS.md #9". Because doc/ is gitignored, these were dead links for anyone reading the repo, exposed the internal doc names and their finding/section numbering, and replaced the actual rationale with a lookup key - so the reader most likely to need the reasoning could not reach it. Each citation is replaced with the substance it pointed at, stated inline. Comments and docstrings only; no behavior change. Verified: python -m compileall passes, full suite 486 passed. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
dovvnloading
added a commit
that referenced
this pull request
Jul 29, 2026
Settings' General page had a Theme select (Dark/Muted/Monochromatic) that persisted a real setTheme intent, but nothing in the SPA ever applied the value: no data-theme attribute, no alternate --gl-surface-* token set, the app rendered identically regardless of selection. Per user decision, removed rather than wired up - building two real alternate palettes is a design investment, not a bug fix, and a persisted preference that provably does nothing is worse than no preference. Removed end to end: the frontend select and its options, the setTheme intent and its handler, get_theme/set_theme on SettingsManager (including the now-pointless in-memory backfill for legacy state files missing the key), the theme field from the app-settings wire contract (regenerated), and the now-stale "Appearance" Help entry that described this exact control. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR repairs chart/graph-node data integrity, rendering behavior, graph lifecycle handling, and persistence.
What changed
Root cause
Chart data rules were duplicated between the agent, scene item, renderer, and persistence layers. Async insertion relied on the current node as a fallback, and charts were represented as loosely attached content without stable graph lifecycle metadata.
Validation
python -m pytest -q