Repository navigation
R8a: give popovers a scroll fallback instead of silent clipping (findings #4, #13) - #178
Merged
Merged
Conversation
…ings #4, #13) The audit listed this bug twice - findings #4 and #13 are the same defect (confirmed identical by an independent re-read of the current code). Every popover through the shared .overlay-popover base class (View, Plugins, Pins, Reasoning, Model) is hosted inside .app-canvas-region, which is overflow:hidden. .overlay-popover itself declared no max-height and no overflow-y, so content taller than the available space - most visibly the View popover's FONT section on a short window - was silently clipped away with no scrollbar and no indication anything was missing. Added max-height: calc(100vh - 96px); overflow-y: auto; to the shared base class. Popovers that already set their own max-height (Reasoning, which opens upward from the composer and caps at min(60vh, 320px)) are unaffected - their own rule simply wins the cascade, since this is only a default for consumers that don't set one. Live-verified at the app's documented 960x600 floor: the View popover's FONT section now renders in full with no scrolling needed (max-height 504px vs 485px of real content). At a shorter 960x450 window, where the content genuinely exceeds the available space, the last color swatch is confirmed off-screen before scrolling and fully reachable after - a real scrollbar, not a resize-and-hope fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The audit listed this bug twice — findings #4 and #13 are the same defect, confirmed identical by an independent re-read of the current code. Every popover through the shared
.overlay-popoverbase class (View, Plugins, Pins, Reasoning, Model) is hosted inside.app-canvas-region, which isoverflow: hidden..overlay-popoveritself declared nomax-heightand nooverflow-y, so content taller than the available space — most visibly the View popover's FONT section on a short window — was silently clipped away with no scrollbar and no indication anything was missing.Change
Added
max-height: calc(100vh - 96px); overflow-y: auto;to the shared base class. Popovers that already set their ownmax-height(Reasoning, which opens upward from the composer and caps atmin(60vh, 320px)) are unaffected — their own rule simply wins the cascade, since this is only a default for consumers that don't set one.Test plan
npx tsc --noEmitnpx vitest run(full suite)npm run lint/npm run buildLive-verified against a running instance at two window sizes:
max-height504px vs 485px of real content).