Skip to content

R8a: give popovers a scroll fallback instead of silent clipping (findings #4, #13) - #178

Merged
dovvnloading merged 1 commit into
mainfrom
r8a/fix-popover-clipping
Jul 29, 2026
Merged

dovvnloading merged 1 commit into
mainfrom
r8a/fix-popover-clipping

Conversation

@dovvnloading

Copy link
Copy Markdown
Owner

Problem

The audit listed this bug twice — findings #4 and #13 are the same defect, confirmed identical by an independent re-read of the current code. Every popover through the shared .overlay-popover base class (View, Plugins, Pins, Reasoning, Model) is hosted inside .app-canvas-region, which is overflow: hidden. .overlay-popover itself declared no max-height and no overflow-y, so content taller than the available space — most visibly the View popover's FONT section on a short window — was silently clipped away with no scrollbar and no indication anything was missing.

Change

Added max-height: calc(100vh - 96px); overflow-y: auto; to the shared base class. Popovers that already set their own max-height (Reasoning, which opens upward from the composer and caps at min(60vh, 320px)) are unaffected — their own rule simply wins the cascade, since this is only a default for consumers that don't set one.

Test plan

Layer Result
npx tsc --noEmit clean
npx vitest run (full suite) 868/868 passed
npm run lint / npm run build clean

Live-verified against a running instance at two window sizes:

  • At the app's documented 960x600 floor: the View popover's FONT section now renders in full with no scrolling needed (computed max-height 504px vs 485px of real content).
  • At a shorter 960x450 window, where content genuinely exceeds the available space: the last color swatch is confirmed off-screen before scrolling and fully reachable after — a real scrollbar, not a resize-and-hope fix.

…ings #4, #13)

The audit listed this bug twice - findings #4 and #13 are the same defect
(confirmed identical by an independent re-read of the current code).

Every popover through the shared .overlay-popover base class (View,
Plugins, Pins, Reasoning, Model) is hosted inside .app-canvas-region, which
is overflow:hidden. .overlay-popover itself declared no max-height and no
overflow-y, so content taller than the available space - most visibly the
View popover's FONT section on a short window - was silently clipped away
with no scrollbar and no indication anything was missing.

Added max-height: calc(100vh - 96px); overflow-y: auto; to the shared base
class. Popovers that already set their own max-height (Reasoning, which
opens upward from the composer and caps at min(60vh, 320px)) are
unaffected - their own rule simply wins the cascade, since this is only a
default for consumers that don't set one.

Live-verified at the app's documented 960x600 floor: the View popover's
FONT section now renders in full with no scrolling needed (max-height
504px vs 485px of real content). At a shorter 960x450 window, where the
content genuinely exceeds the available space, the last color swatch is
confirmed off-screen before scrolling and fully reachable after - a real
scrollbar, not a resize-and-hope fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@dovvnloading
dovvnloading merged commit cae7bd1 into main Jul 29, 2026
2 checks passed
@dovvnloading
dovvnloading deleted the r8a/fix-popover-clipping branch July 29, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant