Align MSTest/testfx package versions and document the sync requirement#55316
Open
Evangelink wants to merge 1 commit into
Open
Align MSTest/testfx package versions and document the sync requirement#55316Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
Bumps the microsoft/testfx dependency group to the latest coherent build
(4.4.0-preview.26366.2 / MTP 2.4.0-preview.26366.2, testfx c1e6453) across all
three places that must agree:
- global.json msbuild-sdks -> MSTest.Sdk (the source generator)
- eng/Version.Details.props -> MSTestPackageVersion + MicrosoftTestingPlatformPackageVersion
- eng/Version.Details.xml -> MSTest, MSTest.Sdk, Microsoft.Testing.Platform (+ Sha)
The MSTest.Sdk source generator emits test registrations against the
MSTest.TestFramework runtime, so these must come from the same testfx build.
A skew breaks the NativeAOT CLI test build ("Zero tests ran" when the generator
lags, CS0234 on DynamicDataSourceResolver when it leads). Adds KEEP-IN-SYNC
comments over each version so future manual edits keep them together. See #55302.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1b315003-e0fc-4a09-865e-c8f4750fe3a5
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the microsoft/testfx dependency versions across the SDK’s three “must match” update points so the MSTest source generator (MSTest.Sdk) and runtime/framework (MSTest.* + Microsoft.Testing.Platform) remain on the same coherent build, preventing NativeAOT test discovery/build breaks.
Changes:
- Bump
global.jsonmsbuild-sdksMSTest.Sdkto4.4.0-preview.26366.2. - Update
eng/Version.Details.xmltestfx dependency versions + Sha to4.4.0-preview.26366.2/2.4.0-preview.26366.2with matching commitc1e6453…. - Update
eng/Version.Details.propspackage version properties and add “KEEP IN SYNC” documentation notes.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates the pinned MSBuild SDK version for MSTest.Sdk to the coherent testfx build. |
| eng/Version.Details.xml | Updates darc-tracked testfx dependencies (versions + Sha) and documents the required synchronization. |
| eng/Version.Details.props | Updates the corresponding version properties and adds guidance to keep the group coherent. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
YuliiaKovalova
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns the microsoft/testfx dependency group to a single coherent build and documents that these versions must stay in sync.
Bumps to the latest coherent testfx build (
4.4.0-preview.26366.2, MTP2.4.0-preview.26366.2, testfx commitc1e6453) across the three places that must agree:global.jsonmsbuild-sdks→MSTest.Sdk(the source generator)eng/Version.Details.props→MSTestPackageVersion+MicrosoftTestingPlatformPackageVersioneng/Version.Details.xml→MSTest,MSTest.Sdk,Microsoft.Testing.Platform(version + Sha)Why
The
MSTest.Sdksource generator emits test registrations that compile and run against theMSTest.TestFrameworkruntime, so both must come from the same testfx build. A skew breaks the NativeAOT CLI test build:Zero tests ran(MTP exit code 8)CS0234onDynamicDataSourceResolver(a type added in a newer testfx build)MSTest.TestAdapter 26366.2also transitively requiresMicrosoft.Testing.Platform 26366.2, so that package moves with the group.Adds
KEEP IN SYNCcomments above each version so future manual edits keep them together. Follow-up to #55302 (which madeMSTest.Sdkdarc-managed) and to a companion PR that stops dependabot from bumpingMSTest.Sdkindependently.