-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Draft] Support Microsoft.Build.Traversal projects in dotnet test (MTP) #55297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Evangelink
wants to merge
5
commits into
main
Choose a base branch
from
dev/amauryleve/dotnet-test-traversal-msbuild-apis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e3b6a6b
Draft: support Microsoft.Build.Traversal projects in dotnet test (MTP)
Evangelink 6b62e59
Add cross-graph de-dup and per-reference Configuration/Platform metad…
Evangelink 0cdfb50
Address review: safe FullPath base dir, config/platform-aware dedup, …
Evangelink 3863987
Merge branch 'main' into dev/amauryleve/dotnet-test-traversal-msbuild…
Evangelink 074fc64
Merge branch 'main' into dev/amauryleve/dotnet-test-traversal-msbuild…
Evangelink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
test/TestAssets/TestProjects/TraversalTestProjects/OtherTestProject/OtherTestProject.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(CurrentTargetFramework)</TargetFramework> | ||
| <OutputType>Exe</OutputType> | ||
|
|
||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <IsTestingPlatformApplication>true</IsTestingPlatformApplication> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Testing.Platform" Version="$(MicrosoftTestingPlatformVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
38 changes: 38 additions & 0 deletions
38
test/TestAssets/TestProjects/TraversalTestProjects/OtherTestProject/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| using Microsoft.Testing.Platform.Builder; | ||
| using Microsoft.Testing.Platform.Capabilities.TestFramework; | ||
| using Microsoft.Testing.Platform.Extensions.Messages; | ||
| using Microsoft.Testing.Platform.Extensions.TestFramework; | ||
|
|
||
| var testApplicationBuilder = await TestApplication.CreateBuilderAsync(args); | ||
|
|
||
| testApplicationBuilder.RegisterTestFramework(_ => new TestFrameworkCapabilities(), (_, __) => new DummyTestAdapter()); | ||
|
|
||
| using var testApplication = await testApplicationBuilder.BuildAsync(); | ||
| return await testApplication.RunAsync(); | ||
|
|
||
| public class DummyTestAdapter : ITestFramework, IDataProducer | ||
| { | ||
| public string Uid => nameof(DummyTestAdapter); | ||
|
|
||
| public string Version => "2.0.0"; | ||
|
|
||
| public string DisplayName => nameof(DummyTestAdapter); | ||
|
|
||
| public string Description => nameof(DummyTestAdapter); | ||
|
|
||
| public Task<bool> IsEnabledAsync() => Task.FromResult(true); | ||
|
|
||
| public Type[] DataTypesProduced => []; | ||
|
|
||
| public Task<CreateTestSessionResult> CreateTestSessionAsync(CreateTestSessionContext context) | ||
| => Task.FromResult(new CreateTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public Task<CloseTestSessionResult> CloseTestSessionAsync(CloseTestSessionContext context) | ||
| => Task.FromResult(new CloseTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public async Task ExecuteRequestAsync(ExecuteRequestContext context) | ||
| { | ||
| context.Complete(); | ||
| await Task.CompletedTask; | ||
| } | ||
| } |
38 changes: 38 additions & 0 deletions
38
test/TestAssets/TestProjects/TraversalTestProjects/TestProject/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| using Microsoft.Testing.Platform.Builder; | ||
| using Microsoft.Testing.Platform.Capabilities.TestFramework; | ||
| using Microsoft.Testing.Platform.Extensions.Messages; | ||
| using Microsoft.Testing.Platform.Extensions.TestFramework; | ||
|
|
||
| var testApplicationBuilder = await TestApplication.CreateBuilderAsync(args); | ||
|
|
||
| testApplicationBuilder.RegisterTestFramework(_ => new TestFrameworkCapabilities(), (_, __) => new DummyTestAdapter()); | ||
|
|
||
| using var testApplication = await testApplicationBuilder.BuildAsync(); | ||
| return await testApplication.RunAsync(); | ||
|
|
||
| public class DummyTestAdapter : ITestFramework, IDataProducer | ||
| { | ||
| public string Uid => nameof(DummyTestAdapter); | ||
|
|
||
| public string Version => "2.0.0"; | ||
|
|
||
| public string DisplayName => nameof(DummyTestAdapter); | ||
|
|
||
| public string Description => nameof(DummyTestAdapter); | ||
|
|
||
| public Task<bool> IsEnabledAsync() => Task.FromResult(true); | ||
|
|
||
| public Type[] DataTypesProduced => []; | ||
|
|
||
| public Task<CreateTestSessionResult> CreateTestSessionAsync(CreateTestSessionContext context) | ||
| => Task.FromResult(new CreateTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public Task<CloseTestSessionResult> CloseTestSessionAsync(CloseTestSessionContext context) | ||
| => Task.FromResult(new CloseTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public async Task ExecuteRequestAsync(ExecuteRequestContext context) | ||
| { | ||
| context.Complete(); | ||
| await Task.CompletedTask; | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
test/TestAssets/TestProjects/TraversalTestProjects/TestProject/TestProject.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(CurrentTargetFramework)</TargetFramework> | ||
| <OutputType>Exe</OutputType> | ||
|
|
||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <IsTestingPlatformApplication>true</IsTestingPlatformApplication> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Testing.Platform" Version="$(MicrosoftTestingPlatformVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <Project Sdk="Microsoft.Build.Traversal/4.1.82"> | ||
| <ItemGroup> | ||
| <ProjectReference Include="TestProject\TestProject.csproj" /> | ||
| <ProjectReference Include="OtherTestProject\OtherTestProject.csproj" /> | ||
| </ItemGroup> | ||
| </Project> |
5 changes: 5 additions & 0 deletions
5
test/TestAssets/TestProjects/TraversalTestProjects/global.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "test": { | ||
| "runner": "Microsoft.Testing.Platform" | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
...estAssets/TestProjects/TraversalTestProjectsNested/LeafTestProject/LeafTestProject.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(CurrentTargetFramework)</TargetFramework> | ||
| <OutputType>Exe</OutputType> | ||
|
|
||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <IsTestingPlatformApplication>true</IsTestingPlatformApplication> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Testing.Platform" Version="$(MicrosoftTestingPlatformVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
49 changes: 49 additions & 0 deletions
49
test/TestAssets/TestProjects/TraversalTestProjectsNested/LeafTestProject/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| using System.Reflection; | ||
| using Microsoft.Testing.Platform.Builder; | ||
| using Microsoft.Testing.Platform.Capabilities.TestFramework; | ||
| using Microsoft.Testing.Platform.Extensions.Messages; | ||
| using Microsoft.Testing.Platform.Extensions.TestFramework; | ||
|
|
||
| // Drop a uniquely-named marker file per process launch so tests can deterministically count how many | ||
| // times this test application actually ran (used to validate traversal de-duplication). | ||
| var markerDir = Environment.GetEnvironmentVariable("TRAVERSAL_MARKER_DIR"); | ||
| if (!string.IsNullOrEmpty(markerDir)) | ||
| { | ||
| Directory.CreateDirectory(markerDir); | ||
| var assemblyName = Assembly.GetEntryAssembly()?.GetName().Name ?? "unknown"; | ||
| File.WriteAllText(Path.Combine(markerDir, $"{assemblyName}-{Guid.NewGuid():N}.marker"), assemblyName); | ||
| } | ||
|
|
||
| var testApplicationBuilder = await TestApplication.CreateBuilderAsync(args); | ||
|
|
||
| testApplicationBuilder.RegisterTestFramework(_ => new TestFrameworkCapabilities(), (_, __) => new DummyTestAdapter()); | ||
|
|
||
| using var testApplication = await testApplicationBuilder.BuildAsync(); | ||
| return await testApplication.RunAsync(); | ||
|
|
||
| public class DummyTestAdapter : ITestFramework, IDataProducer | ||
| { | ||
| public string Uid => nameof(DummyTestAdapter); | ||
|
|
||
| public string Version => "2.0.0"; | ||
|
|
||
| public string DisplayName => nameof(DummyTestAdapter); | ||
|
|
||
| public string Description => nameof(DummyTestAdapter); | ||
|
|
||
| public Task<bool> IsEnabledAsync() => Task.FromResult(true); | ||
|
|
||
| public Type[] DataTypesProduced => []; | ||
|
|
||
| public Task<CreateTestSessionResult> CreateTestSessionAsync(CreateTestSessionContext context) | ||
| => Task.FromResult(new CreateTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public Task<CloseTestSessionResult> CloseTestSessionAsync(CloseTestSessionContext context) | ||
| => Task.FromResult(new CloseTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public async Task ExecuteRequestAsync(ExecuteRequestContext context) | ||
| { | ||
| context.Complete(); | ||
| await Task.CompletedTask; | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
test/TestAssets/TestProjects/TraversalTestProjectsNested/SharedTestProject/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| using System.Reflection; | ||
| using Microsoft.Testing.Platform.Builder; | ||
| using Microsoft.Testing.Platform.Capabilities.TestFramework; | ||
| using Microsoft.Testing.Platform.Extensions.Messages; | ||
| using Microsoft.Testing.Platform.Extensions.TestFramework; | ||
|
|
||
| // Drop a uniquely-named marker file per process launch so tests can deterministically count how many | ||
| // times this test application actually ran (used to validate traversal de-duplication). | ||
| var markerDir = Environment.GetEnvironmentVariable("TRAVERSAL_MARKER_DIR"); | ||
| if (!string.IsNullOrEmpty(markerDir)) | ||
| { | ||
| Directory.CreateDirectory(markerDir); | ||
| var assemblyName = Assembly.GetEntryAssembly()?.GetName().Name ?? "unknown"; | ||
| File.WriteAllText(Path.Combine(markerDir, $"{assemblyName}-{Guid.NewGuid():N}.marker"), assemblyName); | ||
| } | ||
|
|
||
| var testApplicationBuilder = await TestApplication.CreateBuilderAsync(args); | ||
|
|
||
| testApplicationBuilder.RegisterTestFramework(_ => new TestFrameworkCapabilities(), (_, __) => new DummyTestAdapter()); | ||
|
|
||
| using var testApplication = await testApplicationBuilder.BuildAsync(); | ||
| return await testApplication.RunAsync(); | ||
|
|
||
| public class DummyTestAdapter : ITestFramework, IDataProducer | ||
| { | ||
| public string Uid => nameof(DummyTestAdapter); | ||
|
|
||
| public string Version => "2.0.0"; | ||
|
|
||
| public string DisplayName => nameof(DummyTestAdapter); | ||
|
|
||
| public string Description => nameof(DummyTestAdapter); | ||
|
|
||
| public Task<bool> IsEnabledAsync() => Task.FromResult(true); | ||
|
|
||
| public Type[] DataTypesProduced => []; | ||
|
|
||
| public Task<CreateTestSessionResult> CreateTestSessionAsync(CreateTestSessionContext context) | ||
| => Task.FromResult(new CreateTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public Task<CloseTestSessionResult> CloseTestSessionAsync(CloseTestSessionContext context) | ||
| => Task.FromResult(new CloseTestSessionResult() { IsSuccess = true }); | ||
|
|
||
| public async Task ExecuteRequestAsync(ExecuteRequestContext context) | ||
| { | ||
| context.Complete(); | ||
| await Task.CompletedTask; | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
...ssets/TestProjects/TraversalTestProjectsNested/SharedTestProject/SharedTestProject.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>$(CurrentTargetFramework)</TargetFramework> | ||
| <OutputType>Exe</OutputType> | ||
|
|
||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <GenerateProgramFile>false</GenerateProgramFile> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <IsTestingPlatformApplication>true</IsTestingPlatformApplication> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Testing.Platform" Version="$(MicrosoftTestingPlatformVersion)" /> | ||
| </ItemGroup> | ||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.