Reclassify Microsoft.Win32.Msi.Manual.Tests as a standalone manual tool#55272
Open
Evangelink wants to merge 1 commit into
Open
Reclassify Microsoft.Win32.Msi.Manual.Tests as a standalone manual tool#55272Evangelink wants to merge 1 commit into
Evangelink wants to merge 1 commit into
Conversation
Rename Microsoft.Win32.Msi.Manual.Tests to Microsoft.Win32.Msi.ManualTester so it no longer matches the test/UnitTests.proj '*.Tests.csproj' glob and is excluded from the CI test run. This project is an interactive console tool (installs an MSI, requires elevation, has no test framework or test methods), not a real test project. Excluding it unblocks retiring the VSTest dispatch branch, of which it was the last consumer. Fixes #55132 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2f2e2750-581e-4a54-b895-5039fa295d8e
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Reclassifies Microsoft.Win32.Msi.Manual.Tests as a standalone manual MSI installer console tool (not a test project) by renaming it to Microsoft.Win32.Msi.ManualTester, so it no longer matches the *.Tests.csproj glob used by Helix/CI test discovery.
Changes:
- Renamed the manual MSI tool project directory and
.csprojtoMicrosoft.Win32.Msi.ManualTesterto exclude it from CI test runs. - Updated the tool’s namespace and documentation to match the new project name.
- Updated solution references (
sdk.slnx) and the tasks solution filter (src/Tasks/Microsoft.NET.slnf) to the new path.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.Win32.Msi.ManualTester/readme.md | Updates the documented executable name to the renamed manual tool. |
| test/Microsoft.Win32.Msi.ManualTester/Program.cs | Updates the namespace to match the renamed project/tool identity. |
| test/Microsoft.Win32.Msi.ManualTester/Microsoft.Win32.Msi.ManualTester.csproj | Adds the renamed project file defining the manual tool build settings and references. |
| src/Tasks/Microsoft.NET.slnf | Updates the solution filter to include the renamed manual tool project path. |
| sdk.slnx | Updates the main solution to reference the renamed manual tool project. |
Copilot's findings
- Files reviewed: 4/5 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Option 2 from #55132:
Microsoft.Win32.Msi.Manual.Testsis not a real test project — it's an interactive console tool that installs an MSI (requires elevation, renders a progress bar) with no test framework reference and no test methods. This reclassifies it as a standalone manual tool and excludes it from the CI test run.Change
Renamed
test/Microsoft.Win32.Msi.Manual.Tests→test/Microsoft.Win32.Msi.ManualTester(directory +.csproj). The new name no longer matches the**\*.Tests.csprojglob intest/UnitTests.proj, so it's automatically dropped fromSDKCustomTestProject— no explicitRemoveentry is required.Also updated:
Program.cssdk.slnxsrc/Tasks/Microsoft.NET.slnfreadme.mdWhy not migrate to MTP (Option 1)
The project has zero test methods and a custom
Mainentry point (MTP generates its own), so migrating toMSTest.Sdk/MTP would be awkward and semantically wrong. The maintainer discussion on #55132 confirms it's intended as a manual tool, not tied to any test framework.As a bonus, this project was the last consumer of the VSTest dispatch branch in the Helix dispatcher, so excluding it unblocks retiring that branch.
Fixes #55132