Skip to content

Fix race condition in Orleans shopping cart inventory #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimonPasslick wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix race condition in Orleans shopping cart inventory #7122

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedfc5e
fix race condition in Orleans shopping cart inventory (issue #7121)
Jun 23, 2026
bd8f2d5
use explicit lock type
Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion orleans/ShoppingCart/Grains/InventoryGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,17 @@ private async Task PopulateProductCacheAsync()
return;
}

object lockObject = new();

@BillWagner BillWagner Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer seeing the lock object be a System.Threading.Lock type.

@TimonPasslick TimonPasslick Jun 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't know about this explicit lock type. Fixed

await Parallel.ForEachAsync(
state.State,
async (id, _) =>
{
var productGrain = GrainFactory.GetGrain<IProductGrain>(id);
_productCache[id] = await productGrain.GetProductDetailsAsync();
var productDetails = await productGrain.GetProductDetailsAsync();
lock (lockObject)
{
_productCache[id] = productDetails;
}
});
}
}