Add ML-KEM and ML-DSA to well-known OID lookups#131289
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional post-quantum algorithm OIDs (ML-DSA parameter sets and ML-KEM parameter sets) to System.Formats.Asn1’s internal well-known OID tables so AsnWriter / AsnDecoder can use the fast-path mapping for these identifiers.
Changes:
- Extended
WellKnownOids.GetValue/WellKnownOids.GetContentsto include ML-DSA (44/65/87) and ML-KEM (512/768/1024) OIDs. - Updated the packed
datatable and adjusted slice offsets to include the new entries. - Added/extended OID reader/writer tests with the new OID values.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Formats.Asn1/src/System/Formats/Asn1/WellKnownOids.cs | Adds ML-DSA / ML-KEM OIDs to the internal well-known mapping tables (bytes↔string) and updates slice offsets. |
| src/libraries/System.Formats.Asn1/tests/Writer/WriteObjectIdentifier.cs | Extends writer test data with the new OID strings and expected encodings. |
| src/libraries/System.Formats.Asn1/tests/Reader/ReadObjectIdentifier.cs | Adds a decoder test case set for the new OID encodings. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
bartonjs
approved these changes
Jul 23, 2026
vcsjones
enabled auto-merge (squash)
July 23, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ML-KEM and ML-DSA to the well-known OID lookup. The evidence of needing these in the well-known lookups is as such
the S/MIME CA/B working group approved PQC algorithms, ML-DSA and ML-KEM in ballot SMC013. Sections 7.1.3.2.4 and 7.1.3.2.5 of the requirements enable the use of these. HashML-DSA is explicitly excluded.
The Server Cert working group does not have as much progress here but the current draft proposal indicates ML-DSA-44 ML-DSA-87 as a start.
The Code Signing Working Group has largely only looked at ML-DSA-87. The most I was able to glean thus far is from their meeting minutes
Given the discussion so far, I left out SLH-DSA so far as there seems to be no interest in adopting it just yet, so it doesn't need a fast path. Likewise for the HashML-DSA parameters. CompositeML-DSA may be added later as specifications ramp up and start using it, but right now it seems lacking to me.