Skip to content

Arm64: [PAC-RET] NativeAOT changes#128950

Open
SwapnilGaikwad wants to merge 38 commits into
dotnet:mainfrom
SwapnilGaikwad:github-aot-pac
Open

Arm64: [PAC-RET] NativeAOT changes#128950
SwapnilGaikwad wants to merge 38 commits into
dotnet:mainfrom
SwapnilGaikwad:github-aot-pac

Conversation

@SwapnilGaikwad

@SwapnilGaikwad SwapnilGaikwad commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

This PR covers the final subset of changes from #125436 related to NativeAOT as suggested in comment.
It follows the previous work from- #127949, #127838 and #128147.

More details on PAC and its role in software security can be found (here).

cc: @dotnet/arm64-contrib @a74nh @jkotas @dhartglassMSFT

@SwapnilGaikwad
Arm64: [PAC-RET] NativeAOT changes
d14cb42 
As suggested in [comment](dotnet#125436 (comment)), this PR covers subset of changes from dotnet#125436 related to NativeAOT.

More details on PAC and its role in software security can be found ([here](https://llsoftsec.github.io/llsoftsecbook/#sec:pointer-authentication)).
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 3, 2026
@dotnet-policy-service

dotnet-policy-service Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

This was referenced Jun 3, 2026
Open
Open
Open
@SwapnilGaikwad SwapnilGaikwad mentioned this pull request Jun 5, 2026
Open
5 tasks
jkotas
jkotas reviewed Jun 6, 2026
View reviewed changes
Comment thread src/coreclr/inc/daccess.h Outdated
@build-analysis build-analysis Bot mentioned this pull request Jun 8, 2026
Closed
This was referenced Jun 10, 2026
Closed
Closed
@jkotas

jkotas commented Jun 11, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Jun 11, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 11, 2026
Open
Closed
@jkotas

jkotas commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Tests failing on linux-arm64 with

Debug Assertion Violation

Expression: 'IsUnwindable((PTR_VOID)pRegisterSet->IP)'

File: /__w/1/s/src/coreclr/nativeaot/Runtime/unix/UnixNativeCodeManager.cpp, Line: 1476

jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/arm64/GcProbe.asm Outdated
jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/arm64/GcProbe.asm Outdated
jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/unix/UnixNativeCodeManager.cpp Outdated
jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/windows/CoffNativeCodeManager.cpp Outdated
jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/StackFrameIterator.cpp Outdated
This was referenced Jul 3, 2026
Closed
Closed
@SwapnilGaikwad

SwapnilGaikwad commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Failures seem unrelated to the PR.

jkotas
jkotas reviewed Jul 3, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/windows/CoffNativeCodeManager.cpp Outdated
@build-analysis build-analysis Bot mentioned this pull request Jul 6, 2026
Open
jkotas
jkotas reviewed Jul 6, 2026
View reviewed changes
Comment thread src/coreclr/nativeaot/Runtime/unix/UnixNativeCodeManager.cpp Outdated
jkotas
jkotas approved these changes Jul 6, 2026
View reviewed changes

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas

jkotas commented Jul 7, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Jul 7, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky

MichalStrehovsky commented Jul 7, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

This is another PR that is now blocked on #129966. ARM64 testing has been impossible for a week now (Cc @EgorBo).

@build-analysis build-analysis Bot mentioned this pull request Jul 7, 2026
Closed
@MichalStrehovsky

MichalStrehovsky commented Jul 8, 2026

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelines Bot commented Jul 8, 2026

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@SwapnilGaikwad

SwapnilGaikwad commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Current failures don't seem related to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotas jkotas jkotas approved these changes
@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner
@a74nh a74nh Awaiting requested review from a74nh

Assignees

No one assigned

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwapnilGaikwad @jkotas @MichalStrehovsky