test(zookeeper): make close ordering assertion deterministic

[ReubenBond]

Problem

ReadOwner_CanceledCaller_JoinsNativeTasksBeforeClose treated the fake native request's AfterRequest notification as a scheduling barrier. Once that notification fires, the operation owner can legitimately begin closing before the test continuation resumes, making the intermediate closeStarted assertion flaky.

Change

Capture at close entry whether the native request completion notification has already occurred, then assert that recorded ordering after observing close start. This deterministically verifies that the owner joins the admitted native request before close while preserving the cancellation-token, no-second-read, and close-completion lifecycle checks.

Closes #11346

Microsoft Reviewers: Open in CodeFlow

[Copilot]

Copilot review overview

🟢 Approval recommended

The revised assertion correctly verifies ordering without relying on a scheduling barrier.

Review effort: Lite
Findings: None

What changed in this PR

Makes the ZooKeeper close-ordering test deterministic by recording native request completion at close entry.

Changes:

• Removes the racy intermediate closeStarted assertion.
• Verifies the native completion notification preceded close initiation.

File	Description
test/​Extensions/​Orleans.Clustering.ZooKeeper.Tests/​ZooKeeperReadRetryTests.cs	Updates close-ordering assertions in the ZooKeeper retry test.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Code coverage

Metric	Pull request	Current main	Variance
Lines	82.91% (115,362 / 139,149)	82.89% (115,344 / 139,149)	+0.0129 pp
Branches	72.20% (33,474 / 46,361)	72.18% (33,463 / 46,361)	+0.0237 pp

Report-only conclusion: improved.

The current-main baseline is commit 8bc9fd2444 and uses the same reviewed coverage matrix.

Coverage combines every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS, using canonical physical source and branch identities.

The comparison remains report-only while normal line and branch variance is calibrated.

Coverage details

• Pull request commit: 7f59ffaea2
• View the pull request test run and coverage artifacts
• View the trusted coverage reporting run