Fix SOS.Tests musl apphost - #6005
Open
max-charlamb wants to merge 1 commit into
Open
Conversation
Set the test executable runtime identifier from TargetRid so Alpine receives a musl-compatible apphost. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 90d32376-768b-4f8c-a982-54247c372cf3
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing SOS test harness projects, and directly addresses the musl apphost requirement described in the PR.
Pull request overview
This PR ensures the SOS.Tests test executable is built with an apphost for the configured runtime identifier (RID), which is necessary for Alpine (musl) test legs where a glibc apphost would not run.
Changes:
- Set
RuntimeIdentifierforSOS.Teststo$(TargetRid)so the build produces an RID-specific apphost. - Align
SOS.Testswith other SOS test harness executables that already build with$(TargetRid).
File summaries
| File | Description |
|---|---|
src/tests/SOS.Tests/SOS.Tests.csproj |
Builds the test executable with an apphost for the configured $(TargetRid), enabling musl-compatible execution on Alpine legs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
steveisok
approved these changes
Sep 3, 2026
This was referenced Sep 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing