Skip to content

[perf] guard the _AdditionalJavaStubDirectory glob in _FindJavaStubFiles #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Aug 3, 2026
Merged

[perf] guard the _AdditionalJavaStubDirectory glob in _FindJavaStubFiles #12287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,10 +1932,19 @@ because xbuild doesn't support framework reference assemblies.
<Target Name="_FindJavaStubFiles" DependsOnTargets="_GenerateJavaStubs;_ManifestMerger;_ConvertCustomView;$(_AfterConvertCustomView);_GenerateEnvironmentFiles;">
<ItemGroup>
<_JavaStubFiles Include="$(_AndroidIntermediateJavaSourceDirectory)**\*.java" />
<!-- Additional Java source directories compiled in place (e.g. the trimmable type map's
generated Java Callable Wrappers, which are no longer copied into android/src). Track
their *.java as _CompileJava inputs so edits/additions/removals trigger recompilation. -->
</ItemGroup>
<!-- Additional Java source directories compiled in place (e.g. the trimmable type map's
generated Java Callable Wrappers, which are no longer copied into android/src). Track
their *.java as _CompileJava inputs so edits/additions trigger recompilation.

The Condition is required: %() batching over an empty item list still evaluates the
Include once with an empty %(Identity), which degrades to "**\*.java" relative to the
project directory. That recursively walks the entire app tree (bin, obj, Platforms, ...)
on every build and re-adds every android/src stub a second time. -->
<ItemGroup Condition=" '@(_AdditionalJavaStubDirectory->Count())' != '0' ">
<_JavaStubFiles Include="%(_AdditionalJavaStubDirectory.Identity)**\*.java" />
</ItemGroup>
<ItemGroup>
<FileWrites Include="@(_JavaStubFiles)" />
</ItemGroup>
</Target>
Expand Down