Test worldwide text encoding round trips - #4662
Merged
priyankatiwari08 merged 1 commit intoSep 8, 2026
Merged
Conversation
Add multilingual Unicode and UTF-8 coverage for parameters, readers, streaming, and bulk copy across sync and async paths. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test additions are complete, consistent with existing infrastructure, and introduce no unresolved issues.
Pull request overview
Adds comprehensive Unicode and UTF-8 round-trip validation across parameters, readers, packet boundaries, and bulk copy.
Changes:
- Adds worldwide text coverage for sync/async and buffered/streamed paths.
- Expands UTF-8 bulk-copy tests with multilingual data and exact byte validation.
File summaries
| File | Description |
|---|---|
GlobalizationEncodingTests.cs |
Adds Unicode and UTF-8 round-trip tests. |
TestBulkCopyWithUTF8.cs |
Strengthens UTF-8 bulk-copy coverage. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulmedynski
approved these changes
Sep 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4662 +/- ##
==========================================
- Coverage 65.92% 64.61% -1.31%
==========================================
Files 290 284 -6
Lines 44987 67980 +22993
==========================================
+ Hits 29656 43928 +14272
- Misses 15331 24052 +8721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varchar(max)values by both ordinal text equality and exact stored bytes across 512-byte packet boundariesValidation
Focused 14-test suite passed on Windows for
net462,net8.0,net9.0, andnet10.0. Focused plus existing globalization coverage passed 21/21 onnet8.0.Azure DevOps: Task 45861 — Validate Correct Text and Data Encoding