Skip to content

Test worldwide text encoding round trips - #4662

Merged
priyankatiwari08 merged 1 commit into
dotnet:mainfrom
priyankatiwari08:priyankatiwari08-dev/automation/encoding-validation-45861
Sep 8, 2026
Merged

Test worldwide text encoding round trips#4662
priyankatiwari08 merged 1 commit into
dotnet:mainfrom
priyankatiwari08:priyankatiwari08-dev/automation/encoding-validation-45861

Conversation

@priyankatiwari08

Copy link
Copy Markdown
Contributor

Summary

  • add representative worldwide Unicode round-trip coverage for normal and streamed parameters, SQL Server storage, buffered and sequential readers, and sync/async paths
  • validate UTF-8-collated varchar(max) values by both ordinal text equality and exact stored bytes across 512-byte packet boundaries
  • strengthen UTF-8 bulk-copy coverage with multilingual data while preserving sync/async, MARS, and streaming combinations

Validation

  • Tests added or updated
  • Public API changes documented — N/A; no public API changes
  • Verified against customer repro — N/A; compliance validation task
  • Ensure no breaking changes introduced

Focused 14-test suite passed on Windows for net462, net8.0, net9.0, and net10.0. Focused plus existing globalization coverage passed 21/21 on net8.0.

Azure DevOps: Task 45861 — Validate Correct Text and Data Encoding

Add multilingual Unicode and UTF-8 coverage for parameters, readers, streaming, and bulk copy across sync and async paths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 8, 2026 15:15
@priyankatiwari08
priyankatiwari08 requested a review from a team as a code owner September 8, 2026 15:15
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Sep 8, 2026
@priyankatiwari08 priyankatiwari08 added this to the 7.1.0 milestone Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test additions are complete, consistent with existing infrastructure, and introduce no unresolved issues.

Pull request overview

Adds comprehensive Unicode and UTF-8 round-trip validation across parameters, readers, packet boundaries, and bulk copy.

Changes:

  • Adds worldwide text coverage for sync/async and buffered/streamed paths.
  • Expands UTF-8 bulk-copy tests with multilingual data and exact byte validation.
File summaries
File Description
GlobalizationEncodingTests.cs Adds Unicode and UTF-8 round-trip tests.
TestBulkCopyWithUTF8.cs Strengthens UTF-8 bulk-copy coverage.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.61%. Comparing base (7054399) to head (190152a).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4662      +/-   ##
==========================================
- Coverage   65.92%   64.61%   -1.31%     
==========================================
  Files         290      284       -6     
  Lines       44987    67980   +22993     
==========================================
+ Hits        29656    43928   +14272     
- Misses      15331    24052    +8721     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 64.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@priyankatiwari08
priyankatiwari08 requested a review from a team September 8, 2026 17:21
@priyankatiwari08
priyankatiwari08 enabled auto-merge (squash) September 8, 2026 17:21
@priyankatiwari08
priyankatiwari08 merged commit 5a33feb into dotnet:main Sep 8, 2026
214 of 216 checks passed
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants