Repository navigation
⚙️ FEATURE-#252: Improve model_dump_json truncation strategy - #254
Merged
Merged
Conversation
FernandoCelmer
commented
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max=0falsy bug —not self.max→self.max is None{"message": "Context size exceeded"}instead of plain stringsize_messagestring sentinel, use dict fieldBefore vs After
Before: All 3 contexts replaced at once, even if only 1 is large
After: Contexts removed one at a time (largest first)
Changes
max=0skippedself.max is Nonecheck"Context size exceeded"{"message": "Context size exceeded"}Test plan
test_with_max_truncates_largest_context_first— only largest removedtest_with_max_truncates_all_contexts_if_needed— all removed when necessarytest_with_max_zero_truncates—max=0workstest_with_max_clears_errors_if_still_over— errors cleared as last resortCloses #252