Repository navigation
🪲 BUG-#250: Fix _crontab_to_aws to convert */N to 0/N for EventBridge - #251
Merged
Merged
Conversation
FernandoCelmer
force-pushed
the
feature/250
branch
from
April 11, 2026 21:42
9bd5e3e to
1b067b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_fix_step()helper to convert*/Nto0/Nin all cron fields_crontab_to_awsindotflow/cloud/aws/schedule.pytemplate/hooks/post_gen_project.pyProblem
AWS EventBridge does not support
*/Nsyntax in cron expressions. It requiresstart/stepformat (e.g.0/5). The previous_crontab_to_awspassed*/Nthrough unchanged, generating invalid schedules that fail at deploy time.Examples
*/5 * * * *cron(*/5 * * * ? *)cron(0/5 * * * ? *)0 */6 * * *cron(0 */6 * * ? *)cron(0 0/6 * * ? *)30 2 * * *cron(30 2 * * ? *)cron(30 2 * * ? *)(unchanged)Test plan
test_crontab_every_5_minutes—*/5→0/5test_crontab_step_in_hours—*/6in hours →0/6test_crontab_no_step_unchanged— fields without*/are not modifiedCloses #250