Skip to content

Правит ошибки в обработке события fetch в Service Worker #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
monochromer wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Правит ошибки в обработке события fetch в Service Worker #1346

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eb0362
Правит ошибки в обработке события fetch в Service Worker
monochromer Apr 6, 2026
1acdf59
Правит обработку с `endsWith`
monochromer Apr 7, 2026
29afc43
Использует данные объекта URL
monochromer Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,24 +434,31 @@ self.addEventListener('message', async (event) => {
})

self.addEventListener('fetch', async (event) => {
const url = new URL(event.request.url)

// Игнорирует запросы на другие домены
if (!event.request.startsWith(self.location.origin) && event.request.method === 'POST') {
return new Response(fetch(event.request))
if (url.origin !== self.location.origin) {
return

@monochromer monochromer Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чтобы Service Worker не обрабатывал запрос, достаточно досрочно вернуть undefined.

}

// Игнорирует обработку не GET-запросов
if (event.request.method !== 'GET') {
return
}

// Игнорирует кеширование Service Worker
if (event.request.endsWith('sw.js')) {

@monochromer monochromer Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вообще, такая ситуация возможна только если кто-то сделает внутри основного кода fetсh('/sw.js').

return new Response(fetch(event.request))
return
}

// Игнорирует кеширование манифеста
if (event.request.endsWith('manifest.json')) {
return new Response(fetch(event.request))
return
}

// Игнорирует кеширование страниц с параметрами GET запроса
if (event.request.indexOf('.html?') > -1 || event.request.indexOf('.js?') > -1) {

@monochromer monochromer Apr 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут можно было бы заменить такую проверку на что-то типа [...url.searchParams.keys()].legnth > 0 или url.searchParams.toString() !== ''

return new Response(fetch(event.request))
return
}

event.respondWith(
Expand Down
Loading