Skip to content

tests: fix hardcoded skip in test_import_from_url #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yashasm18 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

tests: fix hardcoded skip in test_import_from_url #3414

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9026445
tests: fix hardcoded skip in test_import_from_url
Yashasm18 Jul 8, 2026
4b8a249
Merge branch 'main' into fix/test-import-from-url-skip-condition
Yashasm18 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/integration/api_image_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import contextlib
import json
import os
import shutil
import socket
import socketserver
Expand Down Expand Up @@ -278,7 +279,11 @@ def do_GET(self):

server.shutdown()

@pytest.mark.skipif(True, reason="Doesn't work inside a container - FIXME")
@pytest.mark.skipif(
os.environ.get('DOCKER_HOST', '').startswith('unix:///') and
os.path.exists('/.dockerenv'),
reason="Doesn't work inside a container - HTTP server unreachable from within Docker"
Comment on lines -281 to +285

@thaJeztah thaJeztah Jul 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this skip was originally added in 6c0f718

That PR added various similar skips ("Doesn't work inside a container - FIXME"), but a quick search shows that all of those skips were removed except for this one.

Do we know why this one doesn't work inside a container? And perhaps should we check if that's still the case, or if the Skip could be removed?

If it can't be removed, it would be good to leave a comment that describes why it doesn't work (so that potentially it could be fixed if it's not easy to fix short term)

)
def test_import_from_url(self):
# The crappy test HTTP server doesn't handle large files well, so use
# a small file.
Expand Down
Loading