Skip to content

refactor(compose): rename dependent service parameter - #14243

Closed
vividvisit wants to merge 1 commit into
docker:mainfrom
vividvisit:my_feature_vivid
Closed

vividvisit wants to merge 1 commit into
docker:mainfrom
vividvisit:my_feature_vivid

Conversation

@vividvisit

Copy link
Copy Markdown

What I did

Renamed the local dependant parameter to dependent in waitDependencies and its error message construction.

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

a02936c871a5e1c6a0a5c6485f032fd4

Signed-off-by: vividvisit <vividvisit@outlook.com>
@vividvisit
vividvisit requested review from a team as code owners September 19, 2026 19:00
@glours

glours commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution. Both dependant and dependent are valid spellings, so there's no real error being fixed here, and as-is, this PR doesn't compile: the parameter is renamed at pkg/compose/service_containers.go:162 (and updated at lines 180/182), but the call site at line 187 (s.waitDependency(ctx, dependant, dep, ...)) still references the old dependant name, which no longer exists in scope, go build fails with undefined: dependant.

Closing without merging.

@glours glours closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants