Skip to content

break gc reachability of removed element in binaryheap #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prashant-900 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

break gc reachability of removed element in binaryheap #10952

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e02ac99
break gc reachability of removed element in bianryheap
Prashant-900 Feb 12, 2026
1d14d21
added removeTail function to clear inactive slots instead of clearing…
Prashant-900 Mar 5, 2026
30c34a1
Merge branch 'dlang:master' into fix-issue-10949
Prashant-900 Mar 5, 2026
df2985e
style fixed
Prashant-900 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions std/container/binaryheap.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ and $(D length == capacity), throws an exception.
return 1;
}

/**
Removes the largest element from the heap.
/**
Removes the largest element from the heap.
*/
void removeFront()
{
Expand All @@ -326,6 +326,8 @@ Removes the largest element from the heap.
_store[_length - 1] = move(t1);
}
--_length;
// Break GC reachability of the removed element
_store[length] = typeof(_store[_length]).init;
percolate(_store[], 0, _length);
}

Expand Down
Loading