Skip to content

Two small fixes for __builtins_msvc when targeting AArch64. #23571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
just-harry wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −3
Open

Two small fixes for __builtins_msvc when targeting AArch64. #23571

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ae5f69
Fix `__builtins_msvc.d`'s unittests failing to compile without `-dip1…
just-harry Aug 10, 2026
731e34e
Prevent LDC from emitting `'+prfchw' is not a recognized feature for …
just-harry Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions druntime/src/__builtins_msvc.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,9 +1357,18 @@ version (MSVCIntrinsics)
}
}

version (X86_64_Or_X86)
{
/* prfchw forces prefetchw to be emitted on x86 (which is how MSVC behaves). */
private enum prefetchWriteTarget = "prfchw";
}
else
{
private enum prefetchWriteTarget = "";
}

/* This is trusted so that it's @safe without DIP1000 enabled. */
/* prfchw forces prefetchw to be emitted on x86 (which is how MSVC behaves). */
@llvm_target("prfchw")
@llvm_target(prefetchWriteTarget)
extern(C)
pragma(inline, true)
private void prefetchData(bool write, ubyte level)(scope const(void)* address) @trusted pure nothrow @nogc
Expand Down Expand Up @@ -1528,7 +1537,7 @@ version (MSVCIntrinsics)
}

/* This is trusted so that it's @safe without DIP1000 enabled. */
@safe pure nothrow @nogc unittest
@trusted pure nothrow @nogc unittest
{
static bool test()
{
Expand Down
Loading