make ArrayLiteralExp more abstract - #23552
Merged
Merged
Conversation
WalterBright
force-pushed
the
arrayLength
branch
4 times, most recently
from
August 7, 2026 21:08
2ed0b67 to
ff702fd
Compare
WalterBright
force-pushed
the
arrayLength
branch
from
August 7, 2026 21:51
ff702fd to
72d9546
Compare
thewilsonator
approved these changes
Aug 7, 2026
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In attempting to fix #23367, @ntrel submitted #23372.
But, he ran into problems. The problem is that ArrayLiteralExp has not sufficiently abstracted
elements. What's necessary is to make it a sparse array. This PR is a step in that direction by abstractinglength. Trying to do this all in one go would be too difficult to review.