Skip to content

fix #23524 - Cross-compiling to macos crashes on Windows #23525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rainers wants to merge 1 commit into
base: stable
Choose a base branch
from
+5 −10
Open

fix #23524 - Cross-compiling to macos crashes on Windows #23525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions compiler/src/dmd/glue/package.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,15 +1259,7 @@ private void obj_start(ref OutBuffer objbuf, const(char)* srcfile)
rtlsym_reset();
clearStringTab();

version (Windows)
{
import dmd.backend.mscoffobj;
objmod = MsCoffObj_init(&objbuf, srcfile, null);

@kinke kinke Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this seems to be the only call of that function?

@rainers rainers Aug 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call is hidden in the mixin at

dmd/compiler/src/dmd/backend/obj.d

Line 69 in a24d705

mixin(genRetVal("init(objbuf, filename, csegname)"));

}
else
{
objmod = Obj.initialize(&objbuf, srcfile, null);
}
objmod = Obj.initialize(&objbuf, srcfile, null);

OutBuffer buf;
buf.write("DMD ");
Expand Down
5 changes: 4 additions & 1 deletion compiler/test/compilable/objc_class.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
// EXTRA_OBJC_SOURCES:
// also check cross compilation, ensure targeting 64-bit
// REQUIRED_ARGS: -m64 -os=osx
// doesn't compile with mingw option -mscrtlib=msvcrt120
// DISABLED: win32

import core.attribute : selector;

Expand Down
Loading