append flags of subclasses to the unused bits of bitfields in Expression - #23519
Open
rainers wants to merge 1 commit into
Open
append flags of subclasses to the unused bits of bitfields in Expression#23519rainers wants to merge 1 commit into
rainers wants to merge 1 commit into
Conversation
reduces memory used in derived classes, including padding bytes after flags
DMD perf check
|
Member
Author
|
Improvements are a bit disappointing, probably because most class instance sizes don't jump into the previous 16-byte category used by bump-pointer-allocation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reduces memory used in derived classes, including padding bytes after flags
A minor downside is that non-zero initialization has to be moved to the ctor. For expressions this only occured once.