Skip to content

[dmd/ctfeexpr] Don't copy ArrayLiteralExp.basis more than once #23372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ntrel wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Draft

[dmd/ctfeexpr] Don't copy ArrayLiteralExp.basis more than once #23372

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d24c78f
[dmd/ctfeexpr] Don't copy `ArrayLiteralExp.basis` more than once
ntrel Jul 6, 2026
6e7ed96
Merge branch 'master' into ct-array-basis
thewilsonator Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions compiler/src/dmd/ctfeexpr.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,16 @@ bool needToCopyLiteral(const Expression expr) nothrow
}
}

private Expressions* copyLiteralArray(Expressions* oldelems, Expression basis = null)
// oldelems can have a null element e.g. for `ArrayLiteralExp.elements` when `basis` is set
private Expressions* copyLiteralArray(Expressions* oldelems)
{
if (!oldelems)
return oldelems;
incArrayAllocs();
auto newelems = new Expressions(oldelems.length);
foreach (i, el; *oldelems)
{
(*newelems)[i] = copyLiteral(el ? el : basis).copy();
(*newelems)[i] = el ? copyLiteral(el).copy() : null;
}
return newelems;
}
Expand All @@ -226,9 +227,10 @@ UnionExp copyLiteral(Expression e)
}
if (auto ale = e.isArrayLiteralExp())
{
auto elements = copyLiteralArray(ale.elements, ale.basis);
auto elements = copyLiteralArray(ale.elements);
auto basis = ale.basis ? copyLiteral(ale.basis).copy() : null;

emplaceExp!(ArrayLiteralExp)(&ue, e.loc, e.type, elements);
emplaceExp!(ArrayLiteralExp)(&ue, e.loc, e.type, basis, elements);

ArrayLiteralExp r = ue.exp().isArrayLiteralExp();
r.ownedByCtfe = OwnedBy.ctfe;
Expand Down
Loading