-
-
Notifications
You must be signed in to change notification settings - Fork 828
Removed dependency of setup.cfg from project
#2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p-r-a-v-i-n
wants to merge
4
commits into
django:main
Choose a base branch
from
p-r-a-v-i-n:remove-setupcfg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−78
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3af5f87
Removed dependency of `setup.cfg` from project
p-r-a-v-i-n 9b202b5
Loading flak8 configuration in tox.ini
p-r-a-v-i-n 54489b3
migrate to PEP 735 dependency-groups
p-r-a-v-i-n 3258386
keep tests under [dependency-groups] and update tox and docs accordin…
p-r-a-v-i-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,79 @@ | ||
| [build-system] | ||
| requires = ["setuptools"] | ||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "channels" | ||
| description = "Brings async, event-driven capabilities to Django." | ||
| readme = "README.rst" | ||
| license = "BSD-3-Clause" | ||
| license-files = [ "LICENSE" ] | ||
| authors = [ { name = "Django Software Foundation", email = "foundation@djangoproject.com" } ] | ||
| requires-python = ">=3.10" | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "Environment :: Web Environment", | ||
| "Intended Audience :: Developers", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Programming Language :: Python :: 3.14", | ||
| "Framework :: Django", | ||
| "Framework :: Django :: 5.2", | ||
| "Framework :: Django :: 6.0", | ||
| "Topic :: Internet :: WWW/HTTP", | ||
| ] | ||
| dynamic = [ "version" ] | ||
|
|
||
| dependencies = [ | ||
| "Django>=5.2", | ||
| "asgiref>=3.9.0,<4", | ||
| ] | ||
|
|
||
|
|
||
| [project.optional-dependencies] | ||
| daphne = [ | ||
| "daphne>=4.0.0", | ||
| ] | ||
| types = [ | ||
| "types-channels", | ||
| ] | ||
|
|
||
| [dependency-groups] | ||
|
p-r-a-v-i-n marked this conversation as resolved.
|
||
| tests = [ | ||
| "async-timeout", | ||
| "coverage~=4.5", | ||
| "pytest", | ||
| "pytest-django", | ||
| "pytest-asyncio", | ||
| "selenium", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| Documentation = "https://channels.readthedocs.io/" | ||
| Source = "http://github.com/django/channels" | ||
|
|
||
| [tool.setuptools] | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = { attr = "channels.__version__" } | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| include = [ "channels*" ] | ||
|
|
||
| [tool.flake8] | ||
| exclude = "venv/*,tox/*,docs/*,testproject/*,build/*" | ||
| max-line-length = 88 | ||
| extend-ignore = "E203,W503" | ||
| per-file-ignores = "tests/sample_project/config/asgi.py:E402" | ||
|
|
||
| [tool.isort] | ||
| profile = "black" | ||
|
|
||
| [tool.pytest.ini_options] | ||
| testpaths = ["tests"] | ||
| asyncio_mode = "auto" | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,16 @@ | ||
| [tox] | ||
| requires = | ||
| tox>=4.22 | ||
| envlist = | ||
| py{310,311,312,313,314}-dj52 | ||
| py{312,313,314}-dj60 | ||
| py{312,313,314}-djmain | ||
| qa | ||
|
|
||
| [testenv] | ||
| extras = tests, daphne | ||
| extras = daphne | ||
| dependency_groups = | ||
| tests | ||
| commands = | ||
| pytest -v {posargs} | ||
| deps = | ||
|
|
@@ -19,6 +23,7 @@ skip_install=true | |
| deps = | ||
| black | ||
| flake8 | ||
| flake8-pyproject | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is for loading config for flak8 from pyproject.toml |
||
| isort | ||
| commands = | ||
| flake8 channels tests | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this note because the note was specific to
.[tests],and we will not use that syntax for tests.For extras like
daphne, we use now'.[daphne]'which also avoids the zsh issue