-
Notifications
You must be signed in to change notification settings - Fork 28
ci: route review requests with CODEOWNERS #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rabble
wants to merge
2
commits into
main
Choose a base branch
from
ci/codeowners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Routes review requests automatically when a pull request opens. | ||
| # | ||
| # Branch protection decides whether a pull request may merge; this decides who | ||
| # gets asked. Without it, requesting a reviewer is a step the author has to | ||
| # remember, and a skipped request looks exactly like a completed one. | ||
| # | ||
| # divine-web is not in the per-repo mapping in divine-context | ||
| # PR_REVIEW_TEAMS.md, so the default applies: @divinevideo/reviewers owns | ||
| # review requests for the whole repository. | ||
| # | ||
| # Two ways a line here can fail, one silent, one reported: | ||
| # - A pattern matching no path is silently inert. | ||
| # - A team without write access to this repository is an "Unknown owner": | ||
| # GitHub flags it on this file's page and at | ||
| # /repos/divinevideo/divine-web/codeowners/errors, which takes a ref, so a | ||
| # branch can be checked before merge: | ||
| # gh api "repos/divinevideo/divine-web/codeowners/errors?ref=<branch>" | ||
| # | ||
| # If platform routing is added later, the team needs write access here first | ||
| # (the "Unknown owner" check above covers that), and compute-js/ — the Fastly | ||
| # edge config with the live service id, backends, KV and secret stores — is | ||
| # the path that earns it. wrangler.toml is a three-line Cloudflare Pages | ||
| # build config. Order matters if lines are added: the LAST matching pattern | ||
| # wins, so keep the catch-all first. | ||
|
|
||
| * @divinevideo/reviewers | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrangler.tomlis six lines and three keys — the twoABOUTMEcomments and a blank line come first. "three-key" is what the PR description says, and it is the accurate half.