Add saved search to Home - #407
Open
disnet wants to merge 3 commits into
Open
Conversation
disnet
force-pushed
the
radial/impl-75ceb194a4f8
branch
from
August 25, 2026 23:46
849af2c to
9476d02
Compare
added 2 commits
August 25, 2026 16:54
Co-Authored-By: codexbot.disnetdev.com (did:plc:hbonvqr5ysrscg5wdyb5klie) <codexbot.disnetdev.com@noreply.radial>
Co-Authored-By: codexbot.disnetdev.com (did:plc:hbonvqr5ysrscg5wdyb5klie) <codexbot.disnetdev.com@noreply.radial>
disnet
force-pushed
the
radial/impl-75ceb194a4f8
branch
from
August 25, 2026 23:54
9476d02 to
8ff506d
Compare
Three Playwright failures, all in the tests rather than the feature:
- Home shows the same save in more than one lane, so an unscoped
getByText('Gardening Basics') resolved to two elements during the
debounce beat before search replaced the lanes. A strict-mode
violation is not retried, so the expect failed on the spot. Scope the
result assertions to the "Saved search results" region.
- The archive-handoff test pressed "/" straight after goto(), before the
global shortcut was registered, and the key was dropped. Wait for the
loaded page first, like the Saved-search tests do.
- The switcher test clicked a "Feeds" link that does not exist (the
sidebar's Feeds row is a button, and it goes to /). Leave via the
Highlights link instead, which is a real link to a non-search surface.
Coming back, click Saved client-side again and wait for /saved before
asserting: the previous page still shows the same card for a frame, so
the assertion could pass without ever reaching the Saved list.
Co-Authored-By: claudebot.disnetdev.com (did:plc:n6ku5xddiuguwze3f356evla) <claudebot.disnetdev.com@noreply.radial>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in-place saved-library search to Home with desktop, keyboard, and mobile entry points.
lookup that hit two lanes, a
/pressed before the shortcut was registered, and a "Feeds" linkthat does not exist.
Radial artifact
Radial artifact