feat(web): PR 4 - E2E#3045
Open
paul-nechifor wants to merge 1 commit into
Open
Conversation
paul-nechifor
requested review from
leshy,
mustafab0 and
spomichter
as code owners
July 18, 2026 12:42
Contributor
Greptile SummaryThis PR adds end-to-end support for the Deno relay. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "feat(web): relay process management, e2e..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| parser.add_argument("--secs", type=float, default=0, help="run time; 0 = until Ctrl-C") | ||
| args = parser.parse_args() | ||
|
|
||
| if args.url is not None: |
Contributor
There was a problem hiding this comment.
When --url receives the wtUrl exposed by /api/info, it ends in /viewer. RelayClient.connect(url, "robot") preserves that path, so the relay registers the supposed robot as a viewer and drops its data frames. The demo then reports no delivered odometry despite both connections succeeding.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comment on lines
+313
to
+332
| process = RelayProcess() | ||
| info = process.start() | ||
| robot = await RelayClient.connect(info.wt_url, "robot") | ||
| try: | ||
| await robot.hello() | ||
| writer = robot.latest_writer("cam") | ||
| writer.offer(b"x" * 1000) | ||
| await asyncio.sleep(0.1) # let the pump start | ||
| process.stop() # graceful shutdown sends CONNECTION_CLOSE | ||
|
|
||
| await asyncio.wait_for(robot.wait_closed(), timeout=10.0) | ||
| assert robot.is_closed | ||
| await asyncio.sleep(0.1) # let the pump observe the close | ||
| assert writer._task.done() | ||
| # A dead channel is visible at the producer. | ||
| with pytest.raises(RuntimeError): | ||
| writer.offer(b"y") | ||
| finally: | ||
| await robot.close() | ||
| process.stop() |
Contributor
There was a problem hiding this comment.
If this connection raises after process.start() succeeds, robot is never assigned. The finally block then raises while evaluating await robot.close() and never reaches process.stop(), leaving the Deno relay process alive and able to interfere with later tests.
Suggested change
| process = RelayProcess() | |
| info = process.start() | |
| robot = await RelayClient.connect(info.wt_url, "robot") | |
| try: | |
| await robot.hello() | |
| writer = robot.latest_writer("cam") | |
| writer.offer(b"x" * 1000) | |
| await asyncio.sleep(0.1) # let the pump start | |
| process.stop() # graceful shutdown sends CONNECTION_CLOSE | |
| await asyncio.wait_for(robot.wait_closed(), timeout=10.0) | |
| assert robot.is_closed | |
| await asyncio.sleep(0.1) # let the pump observe the close | |
| assert writer._task.done() | |
| # A dead channel is visible at the producer. | |
| with pytest.raises(RuntimeError): | |
| writer.offer(b"y") | |
| finally: | |
| await robot.close() | |
| process.stop() | |
| process = RelayProcess() | |
| robot: RelayClient | None = None | |
| try: | |
| info = process.start() | |
| robot = await RelayClient.connect(info.wt_url, "robot") | |
| await robot.hello() | |
| writer = robot.latest_writer("cam") | |
| writer.offer(b"x" * 1000) | |
| await asyncio.sleep(0.1) # let the pump start | |
| process.stop() # graceful shutdown sends CONNECTION_CLOSE | |
| await asyncio.wait_for(robot.wait_closed(), timeout=10.0) | |
| assert robot.is_closed | |
| await asyncio.sleep(0.1) # let the pump observe the close | |
| assert writer._task.done() | |
| # A dead channel is visible at the producer. | |
| with pytest.raises(RuntimeError): | |
| writer.offer(b"y") | |
| finally: | |
| try: | |
| if robot is not None: | |
| await robot.close() | |
| finally: | |
| process.stop() |
paul-nechifor
added
the
backport:skip
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## paul/feat/web-3-python-client #3045 +/- ##
=================================================================
+ Coverage 72.36% 72.53% +0.17%
=================================================================
Files 1030 1033 +3
Lines 92720 93056 +336
Branches 8491 8522 +31
=================================================================
+ Hits 67098 67501 +403
+ Misses 23344 23251 -93
- Partials 2278 2304 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Split 4/4 of the web project setup: RelayProcess child management, demo_smoke, Python<->relay e2e test, and _relay_dist wheel bundling (setup.py + MANIFEST.in). Stacked on paul/feat/web-3-python-client.
paul-nechifor
force-pushed
the
paul/feat/web-3-python-client
branch
from
July 18, 2026 22:17
fe724ae to
a7cf9ae
Compare
paul-nechifor
force-pushed
the
paul/feat/web-4-e2e-packaging
branch
from
July 18, 2026 22:17
188bc50 to
aef5a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.