Conversation
kroening
marked this pull request as draft
August 9, 2026 18:41
This extracts the code that turns the data in verilog_set_genvarst into a map into a method.
kroening
force-pushed
the
dk-logikbench-output-part-selects
branch
from
August 11, 2026 02:15
320affc to
c36f819
Compare
kroening
force-pushed
the
dk-logikbench-output-part-selects
branch
from
August 11, 2026 08:54
c36f819 to
5e2c45a
Compare
kroening
marked this pull request as ready for review
August 11, 2026 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes LogikBench failures caused by genvars being dropped while elaborating parameterized module instances.