Repository navigation
Add per-display DDC volume range - #217
Closed
ohmyangboy wants to merge 1 commit into
Closed
ohmyangboy wants to merge 1 commit into
ohmyangboy wants to merge 1 commit into
Conversation
Owner
|
I don't want a second slider that sets the top of the volume slider, so I'm closing this one. Each display already has one volume slider, and I want to keep it to one. For finer steps, hold Option+Shift with the volume keys (since 1.7.0). Each press then moves a quarter step, about 1.5 of 100 on the S2725DSM. Does that cover what you needed? If even the lowest steps are too loud, tell me and I'll look at that. The display ID change (rebuilding the panel when a reconnect gives a display a new ID) looks like a separate fix. If you saw controls stop working after a reconnect, I'd take that as its own PR. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What & why
Add per-display DDC Value Range for finer volume control. Rebuild panel controls when a reconnect changes the display ID.
How tested
make checkand translation checks passed. Verified volume keys and trackpad slider on Dell S2725DSM.Checklist
Localizable.xcstringsfor new strings