Repository navigation
Apply the checked preset again on click and hotkey - #216
Merged
Merged
Conversation
A click or hotkey on the checked preset did nothing. The checkmark only goes off when Crisp itself changes a display, so after a change made elsewhere (System Settings, macOS putting back a stored arrangement) the preset could not be applied again until something else in Crisp was touched (#212). Applying a preset that already matches changes nothing: resolution and HDR are skipped when they match, the arrangement write leaves the displays where they are, and brightness and Image Adjustment fade to the value they already have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A click or hotkey on the checked preset did nothing. The checkmark only goes off when Crisp itself changes a display, so after a change made somewhere else (System Settings, or macOS putting back a stored arrangement) the preset could not be applied again until something else in Crisp was touched. #212 hit this with the arrangement.
Now the click and the hotkey always apply the preset. A preset that already matches changes nothing: resolution and HDR are skipped when they match, brightness and Image Adjustment fade to the value they already have, and an arrangement write with the same origins is a no-op. I checked that last one with a probe. It fires no display reconfiguration callback, and the screen did not flash.
I tested on 1.7.0 and on this change with a real external monitor. After a move from outside Crisp, the 1.7.0 row stayed checked and a click did nothing. With this change, one click put the monitor back, and a click when nothing was different gave no flash. Crisp's own Arrange Displays drag already clears the checkmark in 1.7.0, so the reporter's exact path is not reproduced here, but this covers it either way. I did not run the hotkey live: it goes through the same apply call as the row, behind the same guard.
Refs #212