Repository navigation
Wait longer before the blackout rescue right after a wake - #215
Merged
Merged
Conversation
A monitor coming out of standby can take longer than the rescue's 3 s to come back at a wake. On #168 the display came online about 250 ms after the rescue had given up, so every wake turned the built-in back on and dropped the disconnect. Within 15 s of a wake, full or display, the settle now allows 40 re-polls instead of 10, about 6 s, the same window softReconnect gives a link handshake. An undock while awake keeps the short window, so its dark time doesn't grow. The limit is read on every pass, because the wake notification can arrive after the first callback of the wake has started the settle. Each wake logs a `wake noted` line, and the restoring line now carries its re-poll count, so a capture shows which window applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within 15 s of a wake, the blackout rescue now re-polls 40 times (about 6 s) instead of 10 (about 3 s) before it turns a disconnected built-in back on. On #168 the monitor came back about 250 ms after the rescue had given up. An unplug while awake keeps the 3 s window.
Since 1.7.0 parks the record, a rescue that fires too early no longer loses the disconnect, but the built-in still lights up for a few seconds at each such wake. This removes that.
Tested on my desk with the built-in disconnected next to one monitor: an unplug while awake restores after 10 re-polls, a normal wake stands down at 0 re-polls, and an unplug 8 s after a wake restores after 40 re-polls (6.4 s). The parked record turns the built-in off again after each replug.
Refs #168. The issue stays open until a capture from the reporter shows a wake that needs the longer window.