Repository navigation
Conversation
Owner
|
I'd rather not add this as a setting. The panel resets each time it closes, the way a menu does. A switch that only keeps one section open is the kind of setting I keep out of Crisp. When it's on, the Tools header also stops responding to clicks, and that looks like a bug. I'd like to understand what you use it for, though. What do you usually open Tools for, and how often? That would help me see what's missing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Tools currently collapses whenever the panel closes. Add a default-off Keep Tools Expanded switch in Settings, persisted through SettingsService.
When enabled, Tools stays expanded across panel close/reopen and relaunch, and its header cannot collapse it. Turning the preference off restores normal manual expansion. Other submenus still reset when the panel closes.
How tested
163007a119b024287010824c5a2e16e02814b1cewas independently tested locally with Xcode 27.0 (27A266a) / SDK 27.0. No additional product-code change was needed.make checkpassed strict SwiftLint, unit tests, x86_64 typecheck and all 273 extracted localization keys; Chinese translations are complete../scripts/release.sh v0.0.0-cipassed. App and CLI include arm64/x86_64 slices; deep signature and DMG integrity checks passed.Checklist
./scripts/release.sh v0.0.0-ci, exact source above)Crisp/Resources/Localizable.xcstringsNative SwiftUI fixtures, not installed-app screenshots: