Skip to content

Add a setting to keep Tools expanded - #208

Open
Blazetes wants to merge 1 commit into
didriksg:mainfrom
Blazetes:feature/keep-tools-expanded
Open

Blazetes wants to merge 1 commit into
didriksg:mainfrom
Blazetes:feature/keep-tools-expanded

Conversation

@Blazetes

@Blazetes Blazetes commented Oct 7, 2026 •

Copy link
Copy Markdown

What & why

Tools currently collapses whenever the panel closes. Add a default-off Keep Tools Expanded switch in Settings, persisted through SettingsService.

When enabled, Tools stays expanded across panel close/reopen and relaunch, and its header cannot collapse it. Turning the preference off restores normal manual expansion. Other submenus still reset when the panel closes.

How tested

  • Exact source 163007a119b024287010824c5a2e16e02814b1ce was independently tested locally with Xcode 27.0 (27A266a) / SDK 27.0. No additional product-code change was needed.
  • Local make check passed strict SwiftLint, unit tests, x86_64 typecheck and all 273 extracted localization keys; Chinese translations are complete.
  • Full local ./scripts/release.sh v0.0.0-ci passed. App and CLI include arm64/x86_64 slices; deep signature and DMG integrity checks passed.
  • Native fixtures compile the production SettingsService and PanelSectionState against inert hardware services. They passed preference write/reload in separate processes, Tools-preserving section resets, other-submenu resets and restored normal collapse when disabled.
  • Three-language native rendering passed. Installed-app interaction: not run.

Checklist

  • Builds locally (./scripts/release.sh v0.0.0-ci, exact source above)
  • Added/updated Crisp/Resources/Localizable.xcstrings
  • Screenshot or short clip for UI change

Native SwiftUI fixtures, not installed-app screenshots:

English Simplified Chinese
Settings and expanded Tools Settings and expanded Tools in Chinese

@didriksg

Copy link
Copy Markdown
Owner

I'd rather not add this as a setting. The panel resets each time it closes, the way a menu does. A switch that only keeps one section open is the kind of setting I keep out of Crisp. When it's on, the Tools header also stops responding to clicks, and that looks like a bug.

I'd like to understand what you use it for, though. What do you usually open Tools for, and how often? That would help me see what's missing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants