Use jj commit_id, not change_id, as the reference revision - #293
Open
jaybosamiya wants to merge 1 commit into
Open
Use jj commit_id, not change_id, as the reference revision#293jaybosamiya wants to merge 1 commit into
commit_id, not change_id, as the reference revision#293jaybosamiya wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff-hl-create-revisioncaches the reference file in a temp file keyed by the revision string, assuming that string is content-addressed, and only refetches when it's missing. A jj change ID survives changes to the contents. So after (for example) squashing into@-, the fringe keeps showing the squashed lines as uncommitted.commit_idchanges with the content and fixes it.Related: 6938d20 / #250