Add Ticker transport reliability layer - #1
Merged
Conversation
The `connection_id_update` arm of the spirc `select!` loop is the only arm that treats a handler error as fatal: it `break`s out of the loop, which leads to the "unexpected shutdown" path and terminates the spirc while the librespot process stays alive. The device then silently disappears from Spotify Connect until the process is manually restarted. Such failures are typically transient — `handle_connection_id_update` issues the connect-state PUT (`notify_new_device_appeared`), which can race a dealer websocket reset and surface as `SpircError::FailedDealerSetup`. The connection_id arrives via a long-lived dealer subscription to `hm://pusher/v1/connections/`, and the pusher re-sends a fresh connection_id on every dealer reconnect, so logging and continuing lets the next update retry registration — exactly like every other arm in this loop. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dereksix
force-pushed
the
agent/ticker-reliability
branch
from
August 14, 2026 01:59
dc783b6 to
1da7cf7
Compare
Owner
Author
|
Production-canary validation on MasterServer (2026-08-13 ET):
Known system-level boundary: a second cold Spotify-only request issued immediately after a first can wait on the current single-session bridge while the outgoing track is being captured locally. That is tracked separately from this minimal transport patch and is not being hidden by the cold-start gate. |
Owner
Author
|
Production validation update (Ticker, 2026-08-13/14 ET) Adopted with original-author provenance:
Validation of the runtime baseline at
The soak's only unrelated warning was an already-stale physical |
dereksix
marked this pull request as ready for review
August 14, 2026 02:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The Ticker bar jukebox repeatedly observes Spotify Connect state/context 400 responses and occasional zero-PCM starts. Upstream review throughput is not predictable enough for production reliability to depend on pending merges, so this fork carries only independently reviewed, evidence-backed transport fixes.
The Node audio supervisor remains responsible for PCM gating, retry, local-download racing, make-before-break playback, and rollback. This branch does not treat Spotify control-plane events as proof of audible playback.
Validation
dev(9c7d756)This remains a draft until the Rust checks and live Ticker soak pass.