refactor(my-page): my-page suspense 적용 및 root page server component로 변경 - #392
Draft
chaaerim wants to merge 8 commits into
Draft
refactor(my-page): my-page suspense 적용 및 root page server component로 변경#392chaaerim wants to merge 8 commits into
chaaerim wants to merge 8 commits into
Conversation
LineGu
enabled auto-merge (squash)
January 19, 2024 08:31
dengoyoon
reviewed
Jan 20, 2024
Comment on lines
+95
to
+97
| if (typeof window === 'undefined') { | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
redirectToLoginPage함수가 혹시나 서버 컴포넌트에서 호출될까 염려하여 얼리리턴 해준건가요?
ssr대응이라는게 어떤 문제가 있어서 추가하게 되었는지 궁금합니다..!
Collaborator
There was a problem hiding this comment.
아 실행 시켜보니 window를 참조하는 과정에서 에러가 발생하는군요
Member
Author
There was a problem hiding this comment.
@dengoyoon 네네 맞아요!! 서버에서 렌더 될 때에는 window 참조를 못해서 서버 렌더되는 경우 아예 리턴 시켜서 에러 발생을 막기 위한 코드였습니다
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/routing #392 +/- ##
==================================================
- Coverage 0.08% 0.07% -0.01%
==================================================
Files 171 176 +5
Lines 6166 6254 +88
Branches 171 176 +5
==================================================
Hits 5 5
- Misses 6161 6249 +88 ☔ View full report in Codecov by Sentry. |
minsgy
disabled auto-merge
January 20, 2024 15:01
minsgy
marked this pull request as draft
February 20, 2024 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께