CI hygiene: bump deprecated action versions#161
Open
fcbond wants to merge 1 commit into
Open
Conversation
…ings - actions/checkout@v3 -> v4 and actions/cache@v3 -> v4 (v3 majors are EOL and depend on the deprecated Node 16 runtime) - buildindex action: node16 -> node20 (GitHub is deprecating Node 16 actions; index.js has no Node-16-specific API usage) - .gitignore: add .claude/ so local Claude Code tool settings never get committed to this shared repo Left the committed node_modules/ under .github/actions/buildindex/ alone for now -- replacing it with an ncc-bundled dist/ is a bigger, separate change and this PR is meant to be low-risk. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, low-risk cleanup found while auditing the build pipeline for the BergenTop page-registration fix (merged directly to main separately, since it was time-sensitive with the 2026 Bergen summit imminent):
actions/checkout@v3->v4andactions/cache@v3->v4in the workflows (v3 majors are EOL and depend on the deprecated Node 16 runtime)buildindexcustom action:node16->node20runtime (no Node-16-specific API usage inindex.js, so this should be a no-op behaviorally).gitignore: add.claude/so local Claude Code tool settings never get committedNot included (flagged, not fixed)
.github/actions/buildindex/node_modules/is committed to the repo (482 files). Fixing that properly means bundling with@vercel/nccinto a singledist/index.js, which is a bigger change I didn't want to bundle into this low-risk PR.createdocs.py'sget_change_text()builds agit logshell command by interpolating a wiki filename unescaped (subprocess.check_output([...], shell=True)). Wiki filenames come from user-editable page titles, so this is worth hardening even though it isn't currently known to be exploitable.github.event.inputs.*; forworkflow_calltriggers the correct context isinputs.*. Works today, but is the wrong context and could silently misbehave on other trigger paths.Test plan
BuildDocsworkflow still runs clean end-to-end on this branch (checkout/cache version bump shouldn't change behavior)🤖 Generated with Claude Code