Run socket connect and message polling on a thread - #63
Merged
Conversation
britzl
marked this pull request as draft
January 12, 2026 09:23
britzl
commented
Jan 13, 2026
britzl
commented
Jan 13, 2026
| #endif | ||
|
|
||
| #if defined(HAVE_WSLAY) | ||
| static void ConnectionWorker(void* _conn) |
Contributor
Author
There was a problem hiding this comment.
The entire connect, handshake and websocket polling is now done here in ConnectionWorker in a thread
britzl
commented
Jan 13, 2026
| CLOSE_CONN("Connect sequence timed out"); | ||
| return; | ||
| } | ||
| dmTime::Sleep(10*1000); |
Contributor
Author
There was a problem hiding this comment.
Not sure if this is a reasonable time to wait in between attempts?
britzl
changed the title
britzl
marked this pull request as ready for review
January 13, 2026 11:02
JCash
approved these changes
Jan 13, 2026
JCash
left a comment
JCash
left a comment
Contributor
There was a problem hiding this comment.
only a comment about potential shutdown/rebooting delays while threads are in flight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket connection, handshake and message polling is now done on a thread to not lock up the main thread every update.
Fixes #62