Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff65681b52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ekharkunov
self-requested a review
August 19, 2026 14:50
Summary - Extender code coverage reportSummary
Coveragecom/defold/extender - 43.3%
com/defold/extender/builders - 0%
com/defold/extender/cache - 33.3%
com/defold/extender/cache/info - 100%
com/defold/extender/log - 14.2%
com/defold/extender/metrics - 38.8%
com/defold/extender/process - 73.4%
com/defold/extender/progress - 90.6%
com/defold/extender/remote - 89%
com/defold/extender/services - 58.8%
com/defold/extender/services/cocoapods - 51.9%
com/defold/extender/services/data - 80.7%
com/defold/extender/tracing - 21.8%
com/defold/extender/utils - 0%
|
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffdf7fd5e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ekharkunov
requested changes
Aug 26, 2026
ekharkunov
left a comment
ekharkunov
left a comment
Contributor
There was a problem hiding this comment.
Overall good. See comments and suggestions
| File artifact = new File((String) pathValue).getCanonicalFile(); | ||
| GradleArtifact.Kind artifactKind; | ||
| String resourcePackageName = null; | ||
| if ("exploded-aar".equals(kind)) { |
Contributor
There was a problem hiding this comment.
Is it worth to make strings as constants?
| private static final String JAR_R8_RULE_PREFIX = "META-INF/com.android.tools/r8"; | ||
| private static final String GENERATED_EXTENSION_KEEP_ATTRIBUTES = | ||
| "-keepattributes *Annotation*,Signature,InnerClasses,EnclosingMethod,MethodParameters,Exceptions"; | ||
| static final int MAX_GENERATED_EXTENSION_CLASSES = 32 * 1024; |
Contributor
There was a problem hiding this comment.
I think it's worth to move parameters to config file. In case if we need change it in production it's easier and faster change configs instead of rebuilding and redeploying jar
| if (k.equals("PROGUARD")) { | ||
| continue; | ||
| } | ||
| boolean r8Environment = k.equals("R8") || k.equals("R8_VERSION"); |
Contributor
There was a problem hiding this comment.
I don't understand why we need that code here. If merged app manifests doesn't contain R8-related stuff than we even doesn't hit this. If R8 stuff presented - we will render environment value in any case. What is the purpose of this code?
| return context; | ||
| } | ||
|
|
||
| Map<String, Object> createR8BuilderContext(Map<String, Object> src) throws ExtenderException { |
Contributor
There was a problem hiding this comment.
Why we need such processing specifically for R8-related environment?
Contributor
Author
|
I made fixes (if I understood all right), thnak you! |
ekharkunov
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android builds can now use R8 for code shrinking and obfuscation, replacing the legacy ProGuard path. R8 preserves Android entry points, extension APIs, dependency consumer rules, and ServiceLoader metadata while producing a mapping file for deobfuscation. Builds without
_app/app.keepcontinue to use D8 without shrinking.Fix #566
Technical changes
META-INFmetadata, dex output, andmapping.txt.DM_DEBUG_DISABLE_PROGUARDwithDM_DEBUG_DISABLE_R8.releaseRuntimeClasspath, writes dependency locks and the dependency tree, and emits a deterministic JSON artifact manifest. Gradle is skipped entirely when no dependencies are declared.EXPLODED_AARdirectories and Jetifier-awarePROCESSED_JARartifacts. Standalone JARs remain unprocessed when Jetifier is disabled, whileandroid.useAndroidXstays enabled independently of transformation..gradle/unpackedcache and its extra copy/unpack pass. Artifact paths are canonicalized, validated, deduplicated, and consumed directly from the shared immutable Gradle/AGP cache, reducing duplicate cache storage and filesystem work.jars/classes.jar,jars/libs, resources, assets, JNI libraries, manifests, and consumer rules._app/app.profiles no longer invoke ProGuard, and the R8 path targets Defold’s API 21+ platform baseline.