fix: apply PRs #7500, #7499, #7491 - #1
Open
deepshekhardas wants to merge 1 commit into
Open
Conversation
- fix: safe decode malformed URI route params (refinedev#7500) - fix(core): prevent cached show page data in create forms (refinedev#7499) - fix(antd): add tooltip support for truncated menu labels in ThemedSider (refinedev#7491)
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/react-router/src/safe-decode-uri-component.ts">
<violation number="1" location="packages/react-router/src/safe-decode-uri-component.ts:1">
P2: The `safeDecodeURIComponent` utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on `@refinedev/core` as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -0,0 +1,7 @@ | |||
| export const safeDecodeURIComponent = (value: string) => { | |||
There was a problem hiding this comment.
P2: The safeDecodeURIComponent utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on @refinedev/core as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/react-router/src/safe-decode-uri-component.ts, line 1:
<comment>The `safeDecodeURIComponent` utility is duplicated in three separate packages (core inline, react-router, remix-router) with identical logic. Since both router packages already depend on `@refinedev/core` as a peer dependency, this utility could be exported from core once and imported by the router packages, eliminating the duplication and reducing the risk of behavioral drift.</comment>
<file context>
@@ -0,0 +1,7 @@
+export const safeDecodeURIComponent = (value: string) => {
+ try {
+ return decodeURIComponent(value);
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes from refinedev/refine:
Summary by cubic
Fixes three issues: safely decodes malformed route params to prevent crashes, prevents cached show-page data from overriding create form defaults, and adds tooltips for truncated menu labels in the collapsed sider.
idandtoparams in@refinedev/core,@refinedev/react-router, and@refinedev/remix-routerto avoid errors on malformed URI components.@refinedev/refine-core,useFormstops passingidfor create actions to preventuseOnecache collisions; in@refinedev/refine-react-hook-form,useModalFormavoids resetting defaults on create.@refinedev/antd,ThemedSidershows tooltips for truncated menu labels (including Logout) when collapsed.Written for commit 0e6d1b5. Summary will update on new commits.