Skip to content

build(pyproject): adopt PEP 639 license metadata #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njzjz-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build(pyproject): adopt PEP 639 license metadata #2433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ description = "ReacNetGenerator: An automatic reaction network generator for rea
authors = [
{name = "Jinzhe Zeng", email = "jinzhe.zeng@ustc.edu.cn"},
]
license = {file = "LICENSE"}
license = "LGPL-3.0-or-later"

@coderabbitai coderabbitai Bot Apr 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Sync conda license metadata with the new SPDX expression.

Good update on Line 19, but this creates inconsistent published license metadata: pyproject.toml now says LGPL-3.0-or-later while conda/recipe/meta.yaml:57-59 still declares LGPL-3.0-only. Please align them to avoid compliance ambiguity across package channels.

Proposed follow-up diff (outside this file) 
--- a/conda/recipe/meta.yaml
+++ b/conda/recipe/meta.yaml
@@
-license: LGPL-3.0-only
+license: LGPL-3.0-or-later
   license_family: LGPL
   license_file: LICENSE
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` at line 19, pyproject.toml was changed to license =
"LGPL-3.0-or-later" but the conda recipe still declares "LGPL-3.0-only", causing
inconsistent published metadata; update the conda recipe's license declaration
(the license field in meta.yaml that currently reads "LGPL-3.0-only") to the
matching SPDX expression "LGPL-3.0-or-later" and ensure any related license
metadata (e.g., license_family or license_file references) reflect the same
"or-later" intent so both pyproject.toml and the conda/meta.yaml are aligned.

classifiers = [
"Natural Language :: English",
"Operating System :: POSIX :: Linux",
Expand All @@ -37,7 +37,6 @@ classifiers = [
"Development Status :: 6 - Mature",
"Environment :: Console",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: GNU Lesser General Public License v3 (LGPLv3)",
]
dependencies = [
# "numpy<2; python_version < '3.9'",
Expand Down
Loading