CMake: Introduce CMake dependent options and print build summary#7626
Draft
Growl1234 wants to merge 4 commits into
Draft
CMake: Introduce CMake dependent options and print build summary#7626Growl1234 wants to merge 4 commits into
Growl1234 wants to merge 4 commits into
Conversation
Author
|
There is one RFC about how we should detect and show the version of MPI, as existing version detection logic seems invalid. I currently choose to show the real MPI-standard what an MPI implementation follows, as this is generally available for any MPI implementations through a single
However, one concern is that users might not be used to it, so might there be other easier way? |
- Output crucial information as a build summary - Make MPI implementation detection valid (at least for non-cross build) - Use version of MPI standard one MPI implementation follows [RFC]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
cmake_dependent_optionwith intention to make the dependency handling logic clearer from the beginning of CMake logic.Example:
This means
EXX_DEVis available only whenENABLE_LIBRIis set toON, and defaults toOFF; ifENABLE_LIBRI=OFF, theEXX_DEVoption will be forced to be off. So if one passes-DENABLE_LIBRI=OFF -DEXX_DEV=ONto CMake (by mistake?), the actual resulting logic will be-DENABLE_LIBRI=OFF -DEXX_DEV=OFF.This means
ENABLE_ELPAis available only when bothENABLE_LCAOandENABLE_MPIare set toON.