feat: DH-23321: Persist Browser Logs to IndexedDB

[dgodinez-dh]

• writes log statements to IndexedDB to persist beyond browser refresh
• uses log proxy like existing LogHistory
• prunes old log statements to avoid going over storage quota
• unit tests
• hand tested in Core and Enterprise

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
packages/redux/src/middleware/index.ts	47% smaller
packages/log/src/LogInit.ts	23% smaller
packages/log/src/LogExport.ts	11% smaller
package-lock.json	9% smaller
jest.setup.ts	0% smaller
package.json	0% smaller
packages/app-utils/src/components/AppBootstrap.test.tsx	0% smaller
packages/app-utils/src/components/AppBootstrap.tsx	0% smaller
packages/log/package.json	0% smaller
packages/log/src/LogIndexedDbHistory.test.ts	0% smaller
packages/log/src/LogIndexedDbHistory.ts	0% smaller
packages/log/src/LogInit.test.ts	0% smaller
packages/log/src/index.ts	0% smaller
packages/redux/src/middleware/logUser.test.ts	0% smaller
packages/redux/src/middleware/logUser.ts	0% smaller

[codecov]

Codecov Report

❌ Patch coverage is 93.98496% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.60%. Comparing base (af8215a) to head (f2bb154).

Files with missing lines	Patch %	Lines
packages/log/src/LogIndexedDbHistory.ts	96.59%	8 Missing ⚠️
packages/log/src/LogExport.ts	37.50%	5 Missing ⚠️
packages/log/src/LogInit.ts	72.72%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
+ Coverage   53.33%   53.60%   +0.27%     
==========================================
  Files         816      830      +14     
  Lines       47498    47939     +441     
  Branches    12465    12370      -95     
==========================================
+ Hits        25331    25698     +367     
- Misses      22147    22221      +74     
  Partials       20       20              

Flag	Coverage Δ
unit	53.60% <93.98%> (+0.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

Flush races, cross-user data retention, and runtime compatibility issues must be addressed.

6 open findings

• Preserve Node 16 compatibility for @​deephaven/log · New
• Clear persisted logs across authentication boundaries · New
• Truncate error stacks to the configured entry-length limit · New
• Flush buffered logs after an in-flight write completes · New
• Atomically coordinate pruning across tabs · New
• Add tests for persisted history archive exports · New

What changed in this PR

Adds cross-refresh browser log persistence through IndexedDB and includes persisted logs in support archives.

Changes:

• Adds buffered persistence, retention pruning, formatting, and clearing.
• Integrates persisted history with initialization and log exports.
• Adds IndexedDB tests, mocks, and dependencies.

File	Description
packages/​log/​src/​LogInit.ts	Initializes persistent log history.
packages/​log/​src/​LogIndexedDbHistory.ts	Implements IndexedDB log storage.
packages/​log/​src/​LogIndexedDbHistory.test.ts	Tests persistence and pruning.
packages/​log/​src/​LogExport.ts	Adds persisted logs to exports.
packages/​log/​src/​index.ts	Exports the new API.
packages/​log/​package.json	Adds runtime dependencies.
package.json	Adds the IndexedDB test dependency.
package-lock.json	Locks added dependencies.
jest.setup.ts	Adds structured-clone support for tests.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Session-binding races can expose persisted logs across user boundaries, and the export integration lacks coverage.

2 open findings

• Cross-tab pruning can delete active sessions and misattribute buffered logs · New
• SET_USER is logged before session binding, causing user misattribution · New

6 resolved since last review

• Clear persisted logs across authentication boundaries
• Preserve Node 16 compatibility for @​deephaven/log
• Atomically coordinate pruning across tabs
• Flush buffered logs after an in-flight write completes
• Truncate error stacks to the configured entry-length limit
• Add tests for persisted history archive exports

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Logout retains the previous user's log identity, and repeated initialization creates duplicate persistence listeners.

2 open findings

• Logout retains prior user's persisted logs · New
• Repeated logInit calls duplicate event listeners · New

2 resolved since last review

• SET_USER is logged before session binding, causing user misattribution
• Cross-tab pruning can delete active sessions and misattribute buffered logs

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

User attribution begins too late, stack call sites are inaccurate, and retention can substantially exceed its configured limit.

1 open finding

• Bind log identity before descendant startup work · New

2 resolved since last review

• Repeated logInit calls duplicate event listeners
• Logout retains prior user's persisted logs

Previously missed (2)

In code that hasn't changed since last review

Prune log history based on projected batch entry count

packages/​log/​src/​LogIndexedDbHistory.ts:518

Retention is checked only once per 30 write transactions, while each transaction can contain up to 5,000 buffered entries. Starting at the 20,000-entry default, the store can reach roughly 170,000 entries before this prune runs; a quota failure during those writes disables persistence before pruning can recover it. Enforce the count bound on each batch (while keeping the more expensive quota estimate throttled), or trigger pruning from the projected entry count.

Fix stack first-line detection to preserve the actual caller

packages/​log/​src/​LogIndexedDbHistory.ts:632

This does not reliably report the actual call site. LogHistory.formatStack checks stack[0] === 'Error' (LogHistory.ts:64), but stack[0] is one character, so an ordinary Error\n... stack always uses the wrong splice count and retains an internal console-proxy frame. Correct the helper's first-line detection and assert that persisted output contains the caller rather than the wrapper.

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

Persistence status can be reported incorrectly while its request is pending, and the support-export integration lacks targeted coverage.

0 open findings

1 resolved since last review

• Bind log identity before descendant startup work

Previously missed (1)

In code that hasn't changed since last review

Await persistence before reporting eviction protection status

packages/​log/​src/​LogIndexedDbHistory.ts:477

The persistence request is fire-and-forget, but getFormattedHistory() immediately interprets the default false as “not granted.” If persist() is still pending (for example while the browser waits on permission), an export can incorrectly report that eviction protection was denied even though it later resolves true. Track this request and await it before producing the header, or represent the pending state explicitly.

🧠 Review effort: Balanced