Skip to content

chore: Pin conventional-changelog-conventionalcommits to 10.3.0 - #2754

Merged
mofojed merged 1 commit into
deephaven:mainfrom
mofojed:fix-conventional-commit
Sep 11, 2026
Merged

chore: Pin conventional-changelog-conventionalcommits to 10.3.0#2754
mofojed merged 1 commit into
deephaven:mainfrom
mofojed:fix-conventional-commit

Conversation

@mofojed

@mofojed mofojed commented Sep 11, 2026

Copy link
Copy Markdown
Member

10.4.0 adds a legacy-writer guard that lerna's getChangelogConfig
mistakenly compiles over the preset's modern template, breaking
`lerna version --conventional-commits`.
Revert once lerna ships lerna/lerna#4415
Copilot AI balanced review requested due to automatic review settings September 11, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The manifest and lockfile pins are consistent and correctly implement the temporary workaround.

Pull request overview

Pins the changelog preset to avoid Lerna’s unreleased compatibility fix.

Changes:

  • Pins version 10.3.0 directly and through npm overrides.
  • Synchronizes the lockfile resolution.
File summaries
File Description
package.json Adds the exact dependency pin and override.
package-lock.json Locks the package and template dependency metadata.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.81%. Comparing base (7d9454e) to head (a685f48).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2754    +/-   ##
========================================
  Coverage   52.81%   52.81%            
========================================
  Files         816      816            
  Lines       47351    47351            
  Branches    12229    12417   +188     
========================================
  Hits        25007    25007            
  Misses      22324    22324            
  Partials       20       20            
Flag Coverage Δ
unit 52.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed
mofojed requested a review from vbabich September 11, 2026 17:24
@mofojed
mofojed merged commit 944a994 into deephaven:main Sep 11, 2026
12 checks passed
@mofojed
mofojed deleted the fix-conventional-commit branch September 11, 2026 17:28
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants