Skip to content

ci: use distinct concurrency groups for clang and go linters#440

Merged
vporoshok merged 1 commit into
ppfrom
ci/fix-lint-concurrency-groups
Jul 23, 2026
Merged

ci: use distinct concurrency groups for clang and go linters#440
vporoshok merged 1 commit into
ppfrom
ci/fix-lint-concurrency-groups

Conversation

@vporoshok

Copy link
Copy Markdown
Collaborator

Summary

  • Both clang_lint.yaml and golang_lint.yaml share name: Linter and the concurrency group ${{ github.workflow }}-${{ github.ref }}. Since github.workflow is the workflow name, both files resolved to the same group (Linter-<ref>).
  • With cancel-in-progress: true, the two linters ended up in one concurrency group and cancelled each other — the clang lint job was killed with Canceling since a higher priority waiting request for Linter-... exists whenever the Go linter started on the same ref (and vice versa).
  • Give each workflow its own literal group so they run independently per ref:
    • clang: clang-lint-${{ github.ref }}
    • golangci: golangci-lint-${{ github.ref }}

cancel-in-progress: true is kept, so a new push to the same PR still supersedes the previous in-progress run of that same linter.

Test plan

  • Open/push a PR touching pp/** and Go files; confirm both clang-lint and golangci run to completion without cancelling each other.

Made with Cursor

Both Linter workflows shared name "Linter" and the concurrency group
"${{ github.workflow }}-${{ github.ref }}", so they landed in the same
group and cancelled each other with "higher priority waiting request"
whenever the sibling linter started on the same ref.

Give each workflow its own literal group so clang-lint and golangci-lint
run independently per ref.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vporoshok
vporoshok requested a review from u-veles-a July 23, 2026 07:21
@vporoshok vporoshok self-assigned this Jul 23, 2026
@vporoshok vporoshok added this to the v0.9.0 milestone Jul 23, 2026
@vporoshok
vporoshok merged commit f65be87 into pp Jul 23, 2026
19 of 20 checks passed
@vporoshok
vporoshok deleted the ci/fix-lint-concurrency-groups branch July 23, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants